Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast-url-parser is not actively maintained and has bugs #1044

Closed
imshivam-gupta opened this issue Dec 24, 2023 · 4 comments
Closed

fast-url-parser is not actively maintained and has bugs #1044

imshivam-gupta opened this issue Dec 24, 2023 · 4 comments

Comments

@imshivam-gupta
Copy link

Describe the bug

puny-code was deprecated in node.js 21.5.0 which is used as dependency of fast-url-parser in your project. Since fast-url-parser is not actively maintained it should be replaced by alternative.

To Reproduce Steps to reproduce the behavior:

Run any project with your package as a dependency mainly @graphql/tools

Expected behavior

no warnings should be shown.

Environment:

  • OS: Windows
  • package-name...: fast-url-parser
  • NodeJS: 21.5.0

Additional context

@ardatan
Copy link
Owner

ardatan commented Dec 24, 2023

Could you be more specific? Which bugs do they have? Where do we use it in graphql-tools and how do you get affected?

@imshivam-gupta
Copy link
Author

They have punycode in their project as a dependency which was deprecated in Node.js so all the project with fasturl as internal dependency show deprecation warning. It should be corrected but the project maintainers don not maintain the fasturl project now. I was using project with graphql/tools as dependency and then I found that this project uses fast-url as dependency.

@ardatan
Copy link
Owner

ardatan commented Dec 24, 2023

I understand so it is not the bugs but punycode warning.
We have removed punycode indirect dependency with our fork with this PR;
#990
Could you make sure you are using the latest packages?

@ardatan ardatan closed this as completed Feb 8, 2024
@ardatan
Copy link
Owner

ardatan commented Feb 8, 2024

Closing the issue due to the lack of response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants