Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ownerReference for vulnerabilities resource #26

Closed
danielpacak opened this issue May 22, 2020 · 2 comments · Fixed by #129
Closed

Set ownerReference for vulnerabilities resource #26

danielpacak opened this issue May 22, 2020 · 2 comments · Fixed by #129
Labels
crd/vulnerabilities This issue is somehow related to the vulnerabilities.aquasecurity.github.io resource 🙏 help wanted Extra attention is needed 🚀 enhancement New feature or request 🧑‍🎓 good first issue Good for newcomers
Milestone
Release v0.3.0

Comments

@danielpacak
Copy link
Contributor

By design vulnerabilities are associated with native Kubernetes workloads such as Deployments or Stateful Sets via labels and label selectors. To leverage Kubernetes Garbage Collection we can set the ownerReference for each vulnerabilities resource when we create it.
@danielpacak danielpacak added 🚀 enhancement New feature or request 🧑‍🎓 good first issue Good for newcomers 🙏 help wanted Extra attention is needed labels May 22, 2020
@danielpacak danielpacak added the crd/vulnerabilities This issue is somehow related to the vulnerabilities.aquasecurity.github.io resource label Jun 4, 2020
@krol3
Copy link
Contributor

krol3 commented Jul 28, 2020

I'd like to help it

@danielpacak
Copy link
Contributor Author

@krol3 To avoid conflicts, let's wait for #95 to be merged

@danielpacak danielpacak added this to the Release v0.3.0 milestone Jul 28, 2020
danielpacak added a commit that referenced this issue Aug 24, 2020
@danielpacak
feat: Set ownerReference for vulnerabilities resource
2735657 
Resolves: #26

Signed-off-by: Daniel Pacak <[email protected]>
@danielpacak danielpacak mentioned this issue Aug 24, 2020
Merged
danielpacak added a commit that referenced this issue Aug 24, 2020
@danielpacak
feat: Set ownerReference for vulnerabilities resource
9d22daf 
Resolves: #26

Signed-off-by: Daniel Pacak <[email protected]>
danielpacak added a commit that referenced this issue Aug 24, 2020
@danielpacak
feat: Set ownerReference for vulnerabilities resource
10547e0 
Resolves: #26

Signed-off-by: Daniel Pacak <[email protected]>
danielpacak added a commit that referenced this issue Aug 24, 2020
@danielpacak
feat: Set ownerReference for vulnerabilities resource
6b1d2de 
Resolves: #26

Signed-off-by: Daniel Pacak <[email protected]>
danielpacak added a commit that referenced this issue Aug 24, 2020
@danielpacak
feat: Set ownerReference for vulnerabilities resource
97ff2e8 
Resolves: #26

Signed-off-by: Daniel Pacak <[email protected]>
danielpacak added a commit that referenced this issue Aug 25, 2020
@danielpacak
feat: Set ownerReference for vulnerabilities resource
a15e66e 
Resolves: #26

Signed-off-by: Daniel Pacak <[email protected]>
danielpacak added a commit that referenced this issue Aug 25, 2020
@danielpacak
feat: Set ownerReference for vulnerabilities resource (#129)
d2882c5 
Resolves: #26

Signed-off-by: Daniel Pacak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crd/vulnerabilities This issue is somehow related to the vulnerabilities.aquasecurity.github.io resource 🙏 help wanted Extra attention is needed 🚀 enhancement New feature or request 🧑‍🎓 good first issue Good for newcomers
Projects
None yet
Milestone
Release v0.3.0
Development

Successfully merging a pull request may close this issue.

feat: Set ownerReference for vulnerabilities resource aquasecurity/starboard
2 participants
@danielpacak @krol3