Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set ownerReference for vulnerabilities resource #129

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

danielpacak
Copy link
Contributor

Resolves: #26

Signed-off-by: Daniel Pacak [email protected]

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #129 into master will increase coverage by 0.13%.
The diff coverage is 48.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   42.42%   42.55%   +0.13%     
==========================================
  Files          30       31       +1     
  Lines        1445     1525      +80     
==========================================
+ Hits          613      649      +36     
- Misses        774      804      +30     
- Partials       58       72      +14     
Impacted Files Coverage Δ
pkg/cmd/get_report.go 37.93% <0.00%> (ø)
pkg/find/vulnerabilities/trivy/scanner.go 0.00% <0.00%> (ø)
pkg/find/vulnerabilities/crd/writer.go 25.75% <9.09%> (-2.32%) ⬇️
pkg/kube/object.go 60.78% <59.09%> (-3.11%) ⬇️
pkg/kubebench/crd/writer.go 88.57% <83.33%> (-6.31%) ⬇️
pkg/cmd/commands.go 90.24% <100.00%> (+0.50%) ⬆️
pkg/cmd/find.go 100.00% <100.00%> (ø)
pkg/cmd/find_vulnerabilities.go 74.07% <100.00%> (ø)
pkg/cmd/kube_bench.go 58.53% <100.00%> (ø)
cmd/starboard/main.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be2e87d...a15e66e. Read the comment docs.

@danielpacak danielpacak force-pushed the feat/issue_26/ownerRef_vulns branch 4 times, most recently from 6b1d2de to 97ff2e8 Compare August 24, 2020 18:16
@danielpacak danielpacak force-pushed the feat/issue_26/ownerRef_vulns branch from 97ff2e8 to a15e66e Compare August 25, 2020 06:33
@danielpacak danielpacak requested a review from knqyf263 August 25, 2020 06:39
pkg/kube/object.go Show resolved Hide resolved
@danielpacak danielpacak merged commit d2882c5 into master Aug 25, 2020
@danielpacak danielpacak deleted the feat/issue_26/ownerRef_vulns branch August 25, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set ownerReference for vulnerabilities resource
2 participants