Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONOTCOMMIT] temp override forge to forge-1 to test PR jobs #15645

Closed
wants to merge 1 commit into from
+2 −1
Closed

[DONOTCOMMIT] temp override forge to forge-1 to test PR jobs #15645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion testsuite/forge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,7 +1361,8 @@ def seeded_random_choice(namespace: str, cluster_names: Sequence[str]) -> str:
@envoption("GCP_ZONE", "us-central1-c")
# forge test runner customization
@envoption("FORGE_RUNNER_MODE", "k8s")
@envoption("FORGE_CLUSTER_NAME")
# TEMPORARY: override the cluster name to validate the unused cluster before use
@envoption("FORGE_CLUSTER_NAME", "aptos-forge-1")
Comment on lines +1364 to +1365
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the PR title [DONOTCOMMIT], this change appears to be temporary testing code. The hardcoded cluster name aptos-forge-1 should be removed before merging, restoring the line to its original form: @envoption("FORGE_CLUSTER_NAME"). This ensures the cluster name remains configurable through environment variables as intended.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

# these override the args in forge-cli
@envoption("FORGE_NUM_VALIDATORS")
@envoption("FORGE_NUM_VALIDATOR_FULLNODES")
Expand Down
Loading