-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONOTCOMMIT] temp override forge to forge-1 to test PR jobs #15645
[DONOTCOMMIT] temp override forge to forge-1 to test PR jobs #15645
Conversation
test unused clsuter before enabling
⏱️ 59m total CI duration on this PR
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
# TEMPORARY: override the cluster name to validate the unused cluster before use | ||
@envoption("FORGE_CLUSTER_NAME", "aptos-forge-1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the PR title [DONOTCOMMIT]
, this change appears to be temporary testing code. The hardcoded cluster name aptos-forge-1
should be removed before merging, restoring the line to its original form: @envoption("FORGE_CLUSTER_NAME")
. This ensures the cluster name remains configurable through environment variables as intended.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist