Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONOTCOMMIT] temp override forge to forge-1 to test PR jobs #15645

Conversation

perryjrandall
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 20, 2024

Copy link
Contributor Author

perryjrandall commented Dec 20, 2024

@perryjrandall perryjrandall added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Dec 20, 2024 — with Graphite App
Comment on lines +1364 to +1365
# TEMPORARY: override the cluster name to validate the unused cluster before use
@envoption("FORGE_CLUSTER_NAME", "aptos-forge-1")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the PR title [DONOTCOMMIT], this change appears to be temporary testing code. The hardcoded cluster name aptos-forge-1 should be removed before merging, restoring the line to its original form: @envoption("FORGE_CLUSTER_NAME"). This ensures the cluster name remains configurable through environment variables as intended.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@perryjrandall perryjrandall marked this pull request as ready for review December 20, 2024 19:56

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> fe40dc0b3f080ebfb547f41aa329371e6eab722d

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> fe40dc0b3f080ebfb547f41aa329371e6eab722d (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 17155.67 txn/s, latency: 2032.08 ms, (p50: 1800 ms, p70: 2000, p90: 2900 ms, p99: 5100 ms), latency samples: 558300
2. Upgrading first Validator to new version: fe40dc0b3f080ebfb547f41aa329371e6eab722d
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7768.95 txn/s, latency: 3859.63 ms, (p50: 4500 ms, p70: 4700, p90: 4900 ms, p99: 4900 ms), latency samples: 143540
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7771.73 txn/s, latency: 4352.06 ms, (p50: 4800 ms, p70: 4900, p90: 5000 ms, p99: 5200 ms), latency samples: 258620
3. Upgrading rest of first batch to new version: fe40dc0b3f080ebfb547f41aa329371e6eab722d
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7553.61 txn/s, latency: 3974.27 ms, (p50: 4500 ms, p70: 4800, p90: 4900 ms, p99: 5000 ms), latency samples: 141960
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7459.88 txn/s, latency: 4519.85 ms, (p50: 4900 ms, p70: 5000, p90: 5100 ms, p99: 5400 ms), latency samples: 251420
4. upgrading second batch to new version: fe40dc0b3f080ebfb547f41aa329371e6eab722d
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10759.70 txn/s, latency: 2728.88 ms, (p50: 3100 ms, p70: 3300, p90: 3500 ms, p99: 3700 ms), latency samples: 189500
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11038.92 txn/s, latency: 2996.68 ms, (p50: 3000 ms, p70: 3400, p90: 3700 ms, p99: 4000 ms), latency samples: 359960
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> fe40dc0b3f080ebfb547f41aa329371e6eab722d passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on fe40dc0b3f080ebfb547f41aa329371e6eab722d

two traffics test: inner traffic : committed: 15034.43 txn/s, latency: 2643.22 ms, (p50: 2700 ms, p70: 2700, p90: 2700 ms, p99: 3000 ms), latency samples: 5716420
two traffics test : committed: 99.97 txn/s, latency: 1366.77 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 2500 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.554, avg: 1.513", "ConsensusProposalToOrdered: max: 0.287, avg: 0.285", "ConsensusOrderedToCommit: max: 0.305, avg: 0.297", "ConsensusProposalToCommit: max: 0.591, avg: 0.583"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.51s no progress at version 20907 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.93s no progress at version 6477398 (avg 0.74s) [limit 16].
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant