Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create benchmark #14916

Open
wants to merge 1 commit into
base: 09-11-permission_for_framework
Choose a base branch
from

Conversation

runtian-zhou
Copy link
Contributor

@runtian-zhou runtian-zhou commented Oct 9, 2024

Description

Added new transaction types for APT token transfers, including a permissioned transfer option that uses the permissioned signer framework. This enables both standard APT transfers and permissioned transfers through the transaction generator and e2e benchmark framework.

How Has This Been Tested?

The functionality is integrated into the existing e2e benchmark framework and transaction generator test infrastructure. The new transfer types are added to the test suite alongside other transaction types.

Key Areas to Review

  • New Move module permissioned_transfer.move implementing both standard and permissioned transfer functions
  • Integration of new transaction types into the entry points enum and transaction type arguments
  • Permissioned transfer implementation using the permissioned signer framework

Type of Change

  • New feature
  • Tests

Which Components or Systems Does This Change Impact?

  • Testing Infrastructure

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 9, 2024

⏱️ 1h 55m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-targeted-unit-tests 24m 🟥
rust-move-tests 11m 🟩
check-dynamic-deps 10m 🟩🟩🟩🟩🟩 (+2 more)
rust-cargo-deny 10m 🟩🟩🟩🟩🟩 (+1 more)
rust-move-tests 10m 🟥
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 10m 🟥
rust-move-tests 10m 🟩
rust-lints 4m 🟥
general-lints 3m 🟩🟩🟩🟩🟩 (+1 more)
semgrep/ci 2m 🟩🟩🟩🟩🟩 (+1 more)
rust-check-merge-base 1m 🟩
file_change_determinator 58s 🟩🟩🟩🟩🟩
permission-check 21s 🟩🟩🟩🟩🟩 (+1 more)

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 4m 1m +204%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

runtian-zhou commented Oct 9, 2024

@runtian-zhou runtian-zhou mentioned this pull request Oct 9, 2024
21 tasks
@rahxephon89 rahxephon89 force-pushed the 09-11-permission_for_framework branch from 43f2715 to d468098 Compare October 9, 2024 21:45
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from d468098 to 43f2715 Compare October 9, 2024 21:48
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch 3 times, most recently from 6c002e4 to 44e71be Compare October 9, 2024 23:23
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from 43f2715 to e036793 Compare October 15, 2024 19:04
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 44e71be to 9161080 Compare October 15, 2024 19:04
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from e036793 to e4239a8 Compare October 15, 2024 20:05
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 9161080 to b728e81 Compare October 15, 2024 20:06
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from e4239a8 to d92055d Compare November 15, 2024 20:31
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch 2 times, most recently from ef3c832 to e2fcd91 Compare November 18, 2024 21:33
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from d92055d to 881aa71 Compare November 18, 2024 21:56
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from e2fcd91 to 4caabaf Compare November 18, 2024 21:56
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from 881aa71 to e569dd2 Compare November 18, 2024 22:01
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 4caabaf to e5d6e5d Compare November 18, 2024 22:01
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from e569dd2 to 7723f05 Compare November 18, 2024 22:18
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from e5d6e5d to bf6221c Compare November 18, 2024 22:18
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from 7723f05 to 54bc94c Compare November 19, 2024 18:13
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from bf6221c to 115f8f6 Compare November 19, 2024 18:13
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from 54bc94c to 5d15334 Compare November 19, 2024 18:39
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 115f8f6 to 124c67e Compare November 19, 2024 18:39
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 437a19d to ad68b1a Compare December 2, 2024 02:41
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from 8de6de8 to b10828f Compare December 2, 2024 02:44
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from ad68b1a to 5601d0a Compare December 2, 2024 02:44
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from b10828f to 5a5ba7d Compare December 2, 2024 10:07
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 5601d0a to bb17b9a Compare December 2, 2024 10:07
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from 5a5ba7d to 7ab440e Compare December 4, 2024 06:15
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from bb17b9a to 9471b69 Compare December 4, 2024 06:15
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from 7ab440e to cee59bb Compare December 5, 2024 02:23
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 9471b69 to f09bae0 Compare December 5, 2024 02:23
@runtian-zhou runtian-zhou marked this pull request as ready for review December 14, 2024 15:26
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from cee59bb to 7d27d69 Compare December 16, 2024 09:16
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from f09bae0 to 16346c7 Compare December 16, 2024 09:17
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from 7d27d69 to e00ba7b Compare December 16, 2024 09:29
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 16346c7 to fc085a0 Compare December 16, 2024 09:29
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from e00ba7b to a234dbf Compare December 16, 2024 09:51
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from fc085a0 to 6a2e87a Compare December 16, 2024 09:53
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from a234dbf to 81c1691 Compare December 17, 2024 02:28
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 6a2e87a to a5e92c0 Compare December 17, 2024 02:28
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from 81c1691 to 6db859a Compare December 17, 2024 12:01
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from a5e92c0 to 60ce91a Compare December 17, 2024 12:02
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 60ce91a to b99540a Compare December 18, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant