add permissions for fungible assets operation #14567

runtian-zhou · 2024-09-09T17:09:32Z

Description

Implemented permissions for FA transfer.

Work with current Coin that already migrated to FA as well.
Implemented a new api deposit_with_signer so that permissions can be added to the signer back again.

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

Added test cases. In particular, tested the entire migration path of Coin and FA.

Key Areas to Review

Make sure FA permission works well throughout the entire migration path of FA.

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-09-09T17:09:35Z

⏱️ 2h 15m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
rust-move-unit-coverage	18m	🟩
rust-move-unit-coverage	15m	🟩
rust-move-unit-coverage	15m	🟩
rust-move-unit-coverage	15m	🟩
general-lints	10m	🟩 🟩 🟩 🟩 🟩
check-dynamic-deps	10m	🟩 🟩 🟩 🟩 🟩 (+1 more)
rust-move-tests	9m	🟥
rust-move-tests	9m	🟥
rust-cargo-deny	9m	🟩 🟩 🟩 🟩 🟩
rust-move-tests	8m	🟥
rust-move-unit-coverage	4m	⬜
rust-move-tests	4m	⬜
semgrep/ci	3m	🟩 🟩 🟩 🟩 🟩 (+2 more)
rust-move-tests	3m	🟥
file_change_determinator	1m	🟩 🟩 🟩 🟩 🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

runtian-zhou · 2024-09-09T17:09:44Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2024-09-09T17:24:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.1%. Comparing base (7c5a356) to head (bb315dd).

Additional details and impacted files

@@                                 Coverage Diff                                  @@
##           09-04-implement_rust_logics_for_permissioned_signer   #14567   +/-   ##
====================================================================================
  Coverage                                                 60.1%    60.1%           
====================================================================================
  Files                                                      857      857           
  Lines                                                   210762   210762           
====================================================================================
+ Hits                                                    126723   126744   +21     
+ Misses                                                   84039    84018   -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

igor-aptos · 2024-11-21T06:16:02Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

@@ -194,6 +196,10 @@ module aptos_framework::fungible_asset {
        metadata: Object<Metadata>
    }

+    struct WithdrawPermission has copy, drop, store {
+        metadata_address: address,


let's make this have store_addr as well (by default people will be giving permission to PFS only)

maybe this should be an enum?

I think making it an enum is a great idea. However, I would avoid adding store_addr at the moment as this would require coordination with wallet side how the permission should be displayed.

aptos-move/framework/aptos-framework/sources/fungible_asset.move

igor-aptos · 2024-12-13T23:51:11Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

@@ -6,6 +6,7 @@ module aptos_framework::fungible_asset {
    use aptos_framework::event;


should we have a FungibleAssetManagementPermission - i.e. gating creating fungible assets and modifying their metadata, etc.

not sure if freezing should be part of the same, or separate one

That's not needed thanks to the FA design. Those are already encoded as permission objects.

igor-aptos · 2024-12-13T23:54:05Z

aptos-move/framework/aptos-framework/sources/primary_fungible_store.move

+    ///
+    /// If `owner` is a permissioned signer, the signer will be granted with permission to withdraw
+    /// the same amount of fund in the future.
+    public fun deposit_with_signer(owner: &signer, fa: FungibleAsset) acquires DeriveRefPod {


do we need coin::deposit_with_signer as well?

runtian-zhou force-pushed the asset_permission branch from dec4a79 to 6cd5fd0 Compare September 9, 2024 17:55

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 350db4c to dad258f Compare September 10, 2024 17:25

runtian-zhou force-pushed the asset_permission branch from 6cd5fd0 to 88ad9a1 Compare September 10, 2024 17:25

runtian-zhou mentioned this pull request Sep 10, 2024

add perimission checks to object #14582

Open

10 tasks

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from dad258f to 6b4da66 Compare September 10, 2024 17:29

runtian-zhou force-pushed the asset_permission branch from 88ad9a1 to 5f90e3a Compare September 10, 2024 17:29

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6b4da66 to b1fd015 Compare September 12, 2024 01:50

runtian-zhou force-pushed the asset_permission branch from 5f90e3a to ef7be0f Compare September 12, 2024 01:50

This was referenced Sep 12, 2024

create permissioned signer example #14469

Open

[feature] Add permissioned signer functionality #14521

Open

Add permission check to account #14535

Open

permission for framework #14605

Open

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from b1fd015 to 6592c01 Compare September 17, 2024 05:08

runtian-zhou force-pushed the asset_permission branch from ef7be0f to cd6090b Compare September 17, 2024 05:09

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6592c01 to 54c34ad Compare September 17, 2024 21:23

runtian-zhou force-pushed the asset_permission branch from cd6090b to 0df1c5a Compare September 17, 2024 21:23

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 54c34ad to 1835d3d Compare September 18, 2024 06:22

runtian-zhou force-pushed the asset_permission branch from 0df1c5a to 1bd468b Compare September 18, 2024 06:23

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 1835d3d to 42decc7 Compare September 18, 2024 17:52

runtian-zhou force-pushed the asset_permission branch from 1bd468b to 40796a4 Compare September 18, 2024 17:52

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 42decc7 to 6ac9449 Compare September 19, 2024 00:35

runtian-zhou force-pushed the asset_permission branch from 40796a4 to 4940d7d Compare September 19, 2024 00:35

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6ac9449 to 3ae6a87 Compare September 19, 2024 08:08

runtian-zhou force-pushed the asset_permission branch from 4940d7d to d8742c4 Compare September 19, 2024 08:08

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 3ae6a87 to 7fbfa3e Compare October 4, 2024 20:56

runtian-zhou force-pushed the asset_permission branch from d8742c4 to 5d53f18 Compare October 4, 2024 20:56

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 7fbfa3e to f3015ce Compare October 5, 2024 01:54

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 2a56afe to bde993b Compare November 27, 2024 08:39

runtian-zhou force-pushed the asset_permission branch from c1bc146 to 790baf2 Compare November 27, 2024 08:40

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from bde993b to 415d5c2 Compare December 2, 2024 02:39

runtian-zhou force-pushed the asset_permission branch from 790baf2 to c557d1d Compare December 2, 2024 02:40

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 415d5c2 to e0409cc Compare December 2, 2024 02:43

runtian-zhou force-pushed the asset_permission branch from c557d1d to 1212bb1 Compare December 2, 2024 02:43

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from e0409cc to fb5cd39 Compare December 2, 2024 10:06

runtian-zhou force-pushed the asset_permission branch from 1212bb1 to 57713ac Compare December 2, 2024 10:06

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from fb5cd39 to 0f881a5 Compare December 4, 2024 06:14

runtian-zhou force-pushed the asset_permission branch from 57713ac to 289ab4d Compare December 4, 2024 06:14

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 0f881a5 to 1302971 Compare December 5, 2024 02:22

runtian-zhou force-pushed the asset_permission branch from 289ab4d to 75ffedc Compare December 5, 2024 02:22

igor-aptos reviewed Dec 13, 2024

View reviewed changes

runtian-zhou marked this pull request as ready for review December 14, 2024 15:27

runtian-zhou requested review from junkil-park, davidiw, movekevin and wrwg as code owners December 14, 2024 15:27

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 1302971 to 4505dc2 Compare December 14, 2024 17:59

runtian-zhou requested a review from a team as a code owner December 14, 2024 17:59

runtian-zhou force-pushed the asset_permission branch 2 times, most recently from d09b7ba to 7d7eed9 Compare December 16, 2024 09:16

runtian-zhou mentioned this pull request Dec 16, 2024

Add another flavor of permission api #15609

Draft

22 tasks

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 4505dc2 to 2dfa163 Compare December 16, 2024 16:35

runtian-zhou force-pushed the asset_permission branch from 7d7eed9 to 4db0036 Compare December 16, 2024 16:36

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 2dfa163 to 7b93a7d Compare December 17, 2024 02:27

runtian-zhou force-pushed the asset_permission branch from 4db0036 to d932531 Compare December 17, 2024 02:27

add permissions for fungible assets operation

15dfa6e

runtian-zhou force-pushed the asset_permission branch from d932531 to 15dfa6e Compare December 17, 2024 12:01

runtian-zhou mentioned this pull request Dec 17, 2024

Feature gate permissioned signer #15622

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add permissions for fungible assets operation #14567

add permissions for fungible assets operation #14567

runtian-zhou commented Sep 9, 2024 •

edited

Loading

trunk-io bot commented Sep 9, 2024 •

edited

Loading

runtian-zhou commented Sep 9, 2024 •

edited

Loading

codecov bot commented Sep 9, 2024 •

edited

Loading

igor-aptos Nov 21, 2024

runtian-zhou Dec 14, 2024

igor-aptos Dec 13, 2024

runtian-zhou Dec 14, 2024

igor-aptos Dec 13, 2024

		@@ -6,6 +6,7 @@ module aptos_framework::fungible_asset {
		use aptos_framework::event;

add permissions for fungible assets operation #14567

Are you sure you want to change the base?

add permissions for fungible assets operation #14567

Conversation

runtian-zhou commented Sep 9, 2024 • edited Loading

Description

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

Key Areas to Review

Checklist

trunk-io bot commented Sep 9, 2024 • edited Loading

runtian-zhou commented Sep 9, 2024 • edited Loading

codecov bot commented Sep 9, 2024 • edited Loading

Codecov Report

igor-aptos Nov 21, 2024

Choose a reason for hiding this comment

runtian-zhou Dec 14, 2024

Choose a reason for hiding this comment

igor-aptos Dec 13, 2024

Choose a reason for hiding this comment

runtian-zhou Dec 14, 2024

Choose a reason for hiding this comment

igor-aptos Dec 13, 2024

Choose a reason for hiding this comment

runtian-zhou commented Sep 9, 2024 •

edited

Loading

trunk-io bot commented Sep 9, 2024 •

edited

Loading

runtian-zhou commented Sep 9, 2024 •

edited

Loading

codecov bot commented Sep 9, 2024 •

edited

Loading