Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][ci] deprecation warnings about set-output #18065

Merged
merged 2 commits into from
Oct 18, 2022
Merged

[fix][ci] deprecation warnings about set-output #18065

merged 2 commits into from
Oct 18, 2022

Conversation

tisonkun
Copy link
Member

Upstream fix: amannn/action-semantic-pull-request#208

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

cc @lhotari @nicoloboschi

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 17, 2022
@tisonkun tisonkun changed the title [fix][ci] Fix deprecation warnings about set-output [fix][ci] deprecation warnings about set-output Oct 18, 2022
@tisonkun
Copy link
Member Author

You can compare the output of:

nodece
nodece approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun
Copy link
Member Author

/pulsarbot run-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022 •
edited
Loading

Codecov Report

Merging #18065 (9067f8c) into master (6c65ca0) will increase coverage by 10.98%.
The diff coverage is 57.77%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18065       +/-   ##
=============================================
+ Coverage     34.91%   45.89%   +10.98%     
- Complexity     5707    17592    +11885     
=============================================
  Files           607     1574      +967     
  Lines         53396   128319    +74923     
  Branches       5712    14115     +8403     
=============================================
+ Hits          18644    58897    +40253     
- Misses        32119    63328    +31209     
- Partials       2633     6094     +3461
Flag Coverage Δ
unittests 45.89% <57.77%> (+10.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...org/apache/pulsar/broker/ServiceConfiguration.java 52.07% <ø> (ø)
.../service/SystemTopicBasedTopicPoliciesService.java 62.97% <0.00%> (+11.38%) ⬆️
.../pulsar/broker/stats/BrokerOperabilityMetrics.java 98.21% <ø> (+5.56%) ⬆️
...g/apache/pulsar/compaction/CompactedTopicImpl.java 69.28% <0.00%> (+58.57%) ⬆️
...va/org/apache/pulsar/client/impl/ConsumerBase.java 21.95% <0.00%> (ø)
...ache/pulsar/functions/utils/io/ConnectorUtils.java 0.00% <0.00%> (ø)
...he/pulsar/functions/worker/rest/api/SinksImpl.java 36.82% <50.00%> (ø)
...apache/pulsar/proxy/server/DirectProxyHandler.java 63.63% <50.00%> (ø)
...ulsar/functions/worker/rest/api/ComponentImpl.java 25.26% <57.14%> (ø)
...ava/org/apache/pulsar/common/util/PortManager.java 60.00% <60.00%> (ø)
... and 1128 more

@tisonkun
Copy link
Member Author

/pulsarbot run-failure-checks

@nodece nodece merged commit 561cd3d into apache:master Oct 18, 2022
@tisonkun tisonkun deleted the patch-3 branch October 18, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@nodece nodece nodece approved these changes

Assignees

@tisonkun tisonkun

Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tisonkun @codecov-commenter @nodece @nicoloboschi