Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade @actions/core to avoid deprecation warnings #208

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

tisonkun
Copy link
Contributor

@amannn
Copy link
Owner

amannn commented Oct 14, 2022

Hi and thank you for your PR!

Can you please have a look at the contributors guide to make sure your PR covers the relevant steps?

@tisonkun tisonkun force-pushed the upgrade-actions-core branch from 57e7d51 to b4d61c7 Compare October 14, 2022 10:50
@tisonkun tisonkun force-pushed the upgrade-actions-core branch from b4d61c7 to 4a876fb Compare October 14, 2022 10:51
@tisonkun
Copy link
Contributor Author

@amannn updated and here is the PR on the forked repo: tisonkun#1

@tisonkun
Copy link
Contributor Author

Shall we change the dist linter base branch to "main"?

          if [ $(git diff origin/master --name-only -- 'dist/**' | wc -l) -gt 0 ]
          then
            echo "Please do not update 'dist/'. CI will update it automatically on merge."
            exit 1
          fi

@amannn
Copy link
Owner

amannn commented Oct 14, 2022

Shall we change the dist linter base branch to "main"?

Oh that would be nice, thank you!

@tisonkun
Copy link
Contributor Author

Oh that would be nice, thank you!

So here's the PR: #209

Let me know if there's further work I should do to proceed with these two PRs.

Copy link
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 🙌

@amannn amannn merged commit 91f4126 into amannn:main Oct 17, 2022
@github-actions
Copy link

🎉 This PR is included in version 5.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

tisonkun added a commit to tisonkun/pulsar that referenced this pull request Oct 17, 2022
nodece pushed a commit to apache/pulsar that referenced this pull request Oct 18, 2022
* [fix][ci] Fix deprecation warnings about set-output

Upstream fix: amannn/action-semantic-pull-request#208

* Update .github/workflows/ci-semantic-pull-request.yml
@tisonkun tisonkun deleted the upgrade-actions-core branch November 17, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants