Skip to content

Commit

Permalink
ORC-1520: Removed JDK 8 settings from pom
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?
The PR proposes to remove jdk8 related parameters from pom, since we moved to JDK 17 as part of #1627

### Why are the changes needed?
Since we moved to JDK 17, JDK 8 parameters are not relevant any more.
This shall keep files up to date with changes

### How was this patch tested?
Build runs successfully with the changes.

Closes #1639 from mystic-lama/ORC-1520_remove_jdk8_settings.

Lead-authored-by: mystic-lama <[email protected]>
Co-authored-by: Yiqun Zhang <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
  • Loading branch information
2 people authored and dongjoon-hyun committed Oct 24, 2023
1 parent 5ce80ae commit 36f810e
Showing 1 changed file with 3 additions and 12 deletions.
15 changes: 3 additions & 12 deletions java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@
<java.version>17</java.version>
<junit.version>5.10.0</junit.version>
<maven-assembly-plugin.version>3.6.0</maven-assembly-plugin.version>
<maven-dependency-plugin.version>3.6.0</maven-dependency-plugin.version>
<maven-shade-plugin.version>3.5.0</maven-shade-plugin.version>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<maven.compiler.release>17</maven.compiler.release>
<maven.compiler.useIncrementalCompilation>false</maven.compiler.useIncrementalCompilation>
<maven.version>3.9.4</maven.version>

Expand Down Expand Up @@ -445,7 +445,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<version>3.1.2</version>
<version>${maven-dependency-plugin.version}</version>
<configuration>
<failOnWarning>true</failOnWarning>
<ignoreNonCompile>true</ignoreNonCompile>
Expand Down Expand Up @@ -801,14 +801,5 @@
<module>bench</module>
</modules>
</profile>
<profile>
<id>java8</id>
<activation>
<jdk>1.8</jdk>
</activation>
<properties>
<checkstyle.version>9.3</checkstyle.version>
</properties>
</profile>
</profiles>
</project>

0 comments on commit 36f810e

Please sign in to comment.