Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORC-1512: Drop Java 8/11 and make Java 17 by default #1627

Closed
wants to merge 1 commit into from
Closed

ORC-1512: Drop Java 8/11 and make Java 17 by default #1627

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Sep 26, 2023 •
edited
Loading

What changes were proposed in this pull request?

This PR aims to drop Java 8 and 11 support and make Java 17 as the default and minimum Java version for Apache ORC 2.0.0.

This PR also upgrade GitHub Action test pipelines and Dockefiles.

  • Update GitHub Action Java Versions to Java 17 and 21.
  • Change GitHub Action Java Distribution to Azul Zulu from Eclipse Temurin because temurin doesn't have Java 21 yet.
  • Update Dockerfiles to use Java 17 and 21
  • Delete CentOS7 and Debian10 which requires non-trivial Java installations.

Why are the changes needed?

Apache ORC 2.0 is aligned with Apache Spark 4.0 which dropped Java 8 and 11.

In general, there are some extended support period for Java 11. However, Oracle's Premier Support ends this month, September 2023.

How was this patch tested?

Pass the CIs

@dongjoon-hyun dongjoon-hyun marked this pull request as draft September 26, 2023 03:48
@github-actions github-actions bot added the DOCS label Sep 26, 2023
@dongjoon-hyun dongjoon-hyun added this to the 2.0.0 milestone Sep 26, 2023
@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review September 26, 2023 04:34
@wgtmac
Copy link
Member

wgtmac commented Sep 26, 2023

Thanks @dongjoon-hyun for driving this!

The change itself looks good to me. Is there any risk that other projects (like Apache Hive) may not keep up the pace with this move?

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Sep 30, 2023 •
edited
Loading

Thank you for your review and comments, @wgtmac .

That's true, and Yes, that's intentional.

We need to recommend them to use Apache ORC 1.9.x line instead of ORC 2.0.0.

For Apache Hive community, I know that they are going to release Apache Hive 4.0.0 soon, but it's still based on Apache ORC 1.8.3, not even Apache ORC 1.8.6 or 1.9.x.

dongjoon-hyun
dongjoon-hyun commented Sep 30, 2023
View reviewed changes
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To all,

  • Apache ORC 2.0 will be release in 2024 and will be maintained for next three years up to 2027. Apache ORC 2.0 is the last chance to drop Java 8 and 11. We need to make this decision for our future.
  • All existing projects can use Apache ORC 1.9.x (June 2023 ~ June 2026) also.
  • Lastly, if there is a strong and practical demand, we can have a new release line, Apache ORC 1.10.x.

@dongjoon-hyun
Copy link
Member Author

Let me merge this to proceed along with our one of the biggest downstream projects, Apache Spark project.

@dongjoon-hyun dongjoon-hyun deleted the ORC-1512 branch September 30, 2023 19:51
@paliwalashish paliwalashish mentioned this pull request Oct 17, 2023
Closed
dongjoon-hyun pushed a commit that referenced this pull request Oct 24, 2023
@paliwalashish @guiyanakuang @dongjoon-hyun
ORC-1520: Removed JDK 8 settings from pom
36f810e 
### What changes were proposed in this pull request?
The PR proposes to remove jdk8 related parameters from pom, since we moved to JDK 17 as part of #1627

### Why are the changes needed?
Since we moved to JDK 17, JDK 8 parameters are not relevant any more.
This shall keep files up to date with changes

### How was this patch tested?
Build runs successfully with the changes.

Closes #1639 from mystic-lama/ORC-1520_remove_jdk8_settings.

Lead-authored-by: mystic-lama <[email protected]>
Co-authored-by: Yiqun Zhang <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
cxzl25 pushed a commit to cxzl25/orc that referenced this pull request Jan 11, 2024
@dongjoon-hyun @cxzl25
ORC-1512: Drop Java 8/11 and make Java 17 by default
45a0ffb 
### What changes were proposed in this pull request?

This PR aims to drop Java 8 and 11 support and make Java 17 as the default and minimum Java version for Apache ORC 2.0.0.

This PR also upgrade GitHub Action test pipelines and Dockefiles.
- Update GitHub Action Java Versions to Java 17 and 21.
- Change GitHub Action Java Distribution to `Azul Zulu` from `Eclipse Temurin` because `temurin` doesn't have Java 21 yet.
- Update Dockerfiles to use Java 17 and 21
- Delete CentOS7 and Debian10 which requires non-trivial Java installations.

### Why are the changes needed?

Apache ORC 2.0 is aligned with Apache Spark 4.0 which dropped Java 8 and 11.
- https://issues.apache.org/jira/browse/SPARK-45315 (Drop JDK 8/11 and make JDK 17 by default)

In general, there are some extended support period for Java 11. However, Oracle's Premier Support ends this month, `September 2023`.
- https://www.oracle.com/java/technologies/java-se-support-roadmap.html

### How was this patch tested?

Pass the CIs

Closes apache#1627 from dongjoon-hyun/ORC-1512.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
cxzl25 pushed a commit to cxzl25/orc that referenced this pull request Jan 11, 2024
@paliwalashish @guiyanakuang @cxzl25
ORC-1520: Removed JDK 8 settings from pom
188bce6 
### What changes were proposed in this pull request?
The PR proposes to remove jdk8 related parameters from pom, since we moved to JDK 17 as part of apache#1627

### Why are the changes needed?
Since we moved to JDK 17, JDK 8 parameters are not relevant any more.
This shall keep files up to date with changes

### How was this patch tested?
Build runs successfully with the changes.

Closes apache#1639 from mystic-lama/ORC-1520_remove_jdk8_settings.

Lead-authored-by: mystic-lama <[email protected]>
Co-authored-by: Yiqun Zhang <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun dongjoon-hyun mentioned this pull request Mar 8, 2024
Closed
dongjoon-hyun added a commit to apache/spark that referenced this pull request Mar 8, 2024
@dongjoon-hyun
[SPARK-44115][BUILD] Upgrade Apache ORC to 2.0.0
76b1c12 
### What changes were proposed in this pull request?

This PR aims to Upgrade Apache ORC to 2.0.0 for Apache Spark 4.0.0.

Apache ORC community has 3-year support policy which is longer than Apache Spark. It's aligned like the following.
- Apache ORC 2.0.x <-> Apache Spark 4.0.x
- Apache ORC 1.9.x <-> Apache Spark 3.5.x
- Apache ORC 1.8.x <-> Apache Spark 3.4.x
- Apache ORC 1.7.x (Supported) <-> Apache Spark 3.3.x (End-Of-Support)

### Why are the changes needed?

**Release Note**
- https://github.com/apache/orc/releases/tag/v2.0.0

**Milestone**
- https://github.com/apache/orc/milestone/20?closed=1
  - apache/orc#1728
  - apache/orc#1801
  - apache/orc#1498
  - apache/orc#1627
  - apache/orc#1497
  - apache/orc#1509
  - apache/orc#1554
  - apache/orc#1708
  - apache/orc#1733
  - apache/orc#1760
  - apache/orc#1743

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #45443 from dongjoon-hyun/SPARK-44115.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
sweisdb pushed a commit to sweisdb/spark that referenced this pull request Apr 1, 2024
@dongjoon-hyun @sweisdb
[SPARK-44115][BUILD] Upgrade Apache ORC to 2.0.0
a842622 
### What changes were proposed in this pull request?

This PR aims to Upgrade Apache ORC to 2.0.0 for Apache Spark 4.0.0.

Apache ORC community has 3-year support policy which is longer than Apache Spark. It's aligned like the following.
- Apache ORC 2.0.x <-> Apache Spark 4.0.x
- Apache ORC 1.9.x <-> Apache Spark 3.5.x
- Apache ORC 1.8.x <-> Apache Spark 3.4.x
- Apache ORC 1.7.x (Supported) <-> Apache Spark 3.3.x (End-Of-Support)

### Why are the changes needed?

**Release Note**
- https://github.com/apache/orc/releases/tag/v2.0.0

**Milestone**
- https://github.com/apache/orc/milestone/20?closed=1
  - apache/orc#1728
  - apache/orc#1801
  - apache/orc#1498
  - apache/orc#1627
  - apache/orc#1497
  - apache/orc#1509
  - apache/orc#1554
  - apache/orc#1708
  - apache/orc#1733
  - apache/orc#1760
  - apache/orc#1743

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#45443 from dongjoon-hyun/SPARK-44115.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
This was referenced Aug 16, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamhyun williamhyun Awaiting requested review from williamhyun

@wgtmac wgtmac Awaiting requested review from wgtmac

@omalley omalley Awaiting requested review from omalley

@pgaref pgaref Awaiting requested review from pgaref

@guiyanakuang guiyanakuang Awaiting requested review from guiyanakuang

@pavibhai pavibhai Awaiting requested review from pavibhai

@stiga-huang stiga-huang Awaiting requested review from stiga-huang

Assignees
No one assigned
Labels
BUILD DOCS INFRA JAVA
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dongjoon-hyun @wgtmac