Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-18173: Remove duplicate assertFutureError #18296

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+93 −102
Open

KAFKA-18173: Remove duplicate assertFutureError #18296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...ts/src/test/java/org/apache/kafka/clients/admin/DeleteConsumerGroupOffsetsResultTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public void testTopLevelErrorConstructor() throws InterruptedException {
partitionFutures.completeExceptionally(Errors.GROUP_AUTHORIZATION_FAILED.exception());
DeleteConsumerGroupOffsetsResult topLevelErrorResult =
new DeleteConsumerGroupOffsetsResult(partitionFutures, partitions);
TestUtils.assertFutureError(topLevelErrorResult.all(), GroupAuthorizationException.class);
TestUtils.assertFutureThrows(topLevelErrorResult.all(), GroupAuthorizationException.class);
}

@Test
Expand All @@ -79,9 +79,9 @@ public void testPartitionMissingInResponseErrorConstructor() throws InterruptedE
DeleteConsumerGroupOffsetsResult missingPartitionResult =
new DeleteConsumerGroupOffsetsResult(partitionFutures, partitions);

TestUtils.assertFutureError(missingPartitionResult.all(), IllegalArgumentException.class);
TestUtils.assertFutureThrows(missingPartitionResult.all(), IllegalArgumentException.class);
assertNull(missingPartitionResult.partitionResult(tpZero).get());
TestUtils.assertFutureError(missingPartitionResult.partitionResult(tpOne), IllegalArgumentException.class);
TestUtils.assertFutureThrows(missingPartitionResult.partitionResult(tpOne), IllegalArgumentException.class);
}

@Test
Expand Down Expand Up @@ -110,9 +110,9 @@ private DeleteConsumerGroupOffsetsResult createAndVerifyPartitionLevelError() th
DeleteConsumerGroupOffsetsResult partitionLevelErrorResult =
new DeleteConsumerGroupOffsetsResult(partitionFutures, partitions);

TestUtils.assertFutureError(partitionLevelErrorResult.all(), UnknownTopicOrPartitionException.class);
TestUtils.assertFutureThrows(partitionLevelErrorResult.all(), UnknownTopicOrPartitionException.class);
assertNull(partitionLevelErrorResult.partitionResult(tpZero).get());
TestUtils.assertFutureError(partitionLevelErrorResult.partitionResult(tpOne), UnknownTopicOrPartitionException.class);
TestUtils.assertFutureThrows(partitionLevelErrorResult.partitionResult(tpOne), UnknownTopicOrPartitionException.class);
return partitionLevelErrorResult;
}
}
Loading
Loading