Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18173: Remove duplicate assertFutureError #18296

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

KAFKA-18173: Remove duplicate assertFutureError #18296

wants to merge 1 commit into from
+93 −102

Conversation

peterxcli
Copy link
Contributor

assertFutureError is equal to assertFutureThrows in TestUtils.

@github-actions github-actions bot added triage PRs from the community producer tests Test fixes (including flaky tests) clients labels Dec 22, 2024
@peterxcli
Copy link
Contributor Author

Non-related failed tests.

PlaintextConsumerCallbackTest testSeekPositionAndPauseNewlyAssignedPartitionOnPartitionsAssignedCallback(String, String).quorum=kraft.groupProtocol=consumer org.apache.kafka.common.KafkaException: User rebalance callback throws an error 1.98s
RemoteLogManagerTest testRLMOpsWhenMetadataIsNotReady() org.mockito.exceptions.verification.NoInteractionsWanted:No interactions wanted here:-> at kafka.log.remote.RemoteLogManagerTest.testRLMOpsWhenMetadataIsNotReady(RemoteLogManagerTest.java:3706)But found this interaction on mock 'remoteLogMetadataManager':-> at kafka.log.remote.RemoteLogManager$RLMTask.run(RemoteLogManager.java:815)***For your reference, here is the list of all invocations ([?] - means unverified).1. -> at kafka.log.remote.RemoteLogManager.configureRLMM(RemoteLogManager.java:413)2. -> at kafka.log.remote.RemoteLogManager.onLeadershipChange(RemoteLogManager.java:478)3. -> at kafka.log.remote.RemoteLogManager$RLMTask.run(RemoteLogManager.java:815)4. -> at kafka.log.remote.RemoteLogManager$RLMTask.run(RemoteLogManager.java:815)5. [?]-> at kafka.log.remote.RemoteLogManager$RLMTask.run(RemoteLogManager.java:815) 0.07s
PlaintextAdminIntegrationTest testConsumerGroupsDeprecatedConsumerGroupState(String, String).quorum=kraft.groupProtocol=consumer org.opentest4j.AssertionFailedError: Expected the offset for partition 0 to eventually become 1. 21.79s
DynamicBrokerReconfigurationTest testMetricsReporterUpdate(String, String).quorum=kraft.groupProtocol=classic org.opentest4j.AssertionFailedError: expected: <1> but was: <0> 2.18s
PlaintextAdminIntegrationTest testConsumerGroupsDeprecatedConsumerGroupState(String, String).quorum=kraft.groupProtocol=consumer org.opentest4j.AssertionFailedError: Expected the offset for partition 0 to eventually become 1. 21.56s
PlaintextAdminIntegrationTest testConsumerGroups(String, String).quorum=kraft.groupProtocol=consumer org.opentest4j.AssertionFailedError: Expected the offset for partition 0 to eventually become 1. 21.79s

ijuma
ijuma reviewed Dec 24, 2024
View reviewed changes
clients/src/test/java/org/apache/kafka/test/TestUtils.java
fail("Expected a " + exceptionClass.getSimpleName() + " exception, but got success.");
} catch (ExecutionException ee) {
Throwable cause = ee.getCause();
assertEquals(exceptionClass, cause.getClass(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining method has a less useful message, it doesn't include the expected class. Perhaps we should address it as part of this change.

@github-actions github-actions bot removed the triage PRs from the community label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijuma ijuma ijuma left review comments

Assignees
No one assigned
Labels
ci-approved clients producer tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterxcli @ijuma @FrankYang0529