GH-2371: Add tooltip to progress bars (via title attr) #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And I think it should be OK to skip tests for this one (not sure how hard/easy it'd be to test that the tooltip appears... we could test for the title attribute if others want...) |
|
Used wrong GH issue 😮💨 give me a sec to fix that... |
kinow
changed the title
|
Fixed, only the branch name remains gh-2370, but I think that's harmless. Sorry. |
afs
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #2371
Pull request Description:
Adds tooltips in case you have very long list and the text is not visible in the progress bars.
Here's a preview of the tooltip (dark tooltip, over one of the progress bars, mouse pointer not displayed).
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.