Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuseki UI Add Data Dataset graph name not escaped #2370

Open
afs opened this issue Mar 27, 2024 · 5 comments · May be fixed by #2373
Open

Fuseki UI Add Data Dataset graph name not escaped #2370

afs opened this issue Mar 27, 2024 · 5 comments · May be fixed by #2373
Assignees

Comments

@afs
Copy link
Member

afs commented Mar 27, 2024

Version

4.8.0

What happened?

(Transferred from https://issues.apache.org/jira/browse/JENA-2359)

@jmkeil wrote:

If uploading some data through the Fuseki UI (#/dataset/<dataset>/upload), the name of the target graph will not be URI save escaped for the HTTP service request. If I enter e.g. http://example.org/dataset#graph, the data will be added to the named graph http://example.org/dataset. However, if I enter http://example.org/dataset%23graph, the data will be added to the named graph http://example.org/dataset#graph.

@jmkeil
Copy link
Contributor

jmkeil commented Mar 27, 2024

Off topic question: Is GitHub now the official place to report and discuss Apache Jena issues?

@afs
Copy link
Member Author

afs commented Mar 27, 2024

Off topic question: Is GitHub now the official place to report and discuss Apache Jena issues?

GitHub issues has become the preferred channel for Jena. We have been running them in parallel and github is now much busier. github is now preferred for Jena. We have also enabled the discussions forum.

We keep JIRA around. Some people who may dip in and out occasionally are used to using it.

ASF generally now requires some confirmation for any new JIRA user signups due to JIRA spam. JIRA spam had become a real problem for the foundation. Jena only got a small amount, other projects were not so lucky.

For Jena, >80% of signups have been spam attempts.

Other Apache projects still use JIRA as their primary tracker.

@kinow
Copy link
Member

kinow commented Mar 27, 2024

@afs how do you think this should be tackled? Escape on UI? Escape on backend? Escape on both (not sure if double-escaping could lead to some other issue).

(Although re-reading it, maybe it can only be fixed on the UI?)

@jmkeil
Copy link
Contributor

jmkeil commented Mar 27, 2024

It must be handled in the front-end, as the request to the back-end is a SPARQL 1.1 Graph Store HTTP Protocol POST request with the graph IRI as URL parameter.

@kinow
Copy link
Member

kinow commented Mar 27, 2024

Reproduced, found where to change. Just checking what's the possible best way to fix it, then will prepare a draft PR and if that looks OK will write a test for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants