fix: enable DF's nested_expressions feature by in datafusion-substrait tests to make them pass #13857
Conversation
…ts to make them pass fixes apache#13854
|
Fyi @alamb |
Yeah I think they are run like this |
There was a problem hiding this comment.
Thanks @Blizzara -- I verified this works locally for me too.
It is annoying that CI didn't catch this but I also think it might be too much effort / overhead to add a specific ci check for each sub package.If it happens again we can maybe add some more tests
|
Thank you very much @Blizzara -- great 🕵️ I also filed a follow up ticket to make the error message more helpful |
Which issue does this PR close?
Closes #13854
Rationale for this change
https://github.com/apache/datafusion/pull/13594/files#diff-d195b6dfaaed44b9828e145dc50c075c77b7faf8f44783ca5e6eda2c617af928L39 removed DF default features from the substrait crate. That broke some tests that depended on stuff coming from nested_expressions feature.
Interestingly, the tests still passed in CI but failed when run locally - maybe due to CI running a whole bunch of tests at once and thus compiling DF with different set of features, or something?
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
No - but in the original PR that caused the issue, that might be a breaking change to some consumer if someone has disabled default_features for DF but things have been working still because datafusion-substrait has been pulling those features in anyways. Not sure if that can happen - I checked our internal stuff and that seems to work fine against a recent commit on main.