substrait_integration integration tests are failing

[alamb]

Describe the bug

substrait_integration integration tests are failing

To Reproduce

on main at 9f530dd

cargo test -p datafusion-substrait

Fails like this:

failures:

---- cases::roundtrip_logical_plan::roundtrip_literal_list stdout ----
Error: Internal("Expected a simplified result, but none was found")

---- cases::roundtrip_logical_plan::roundtrip_values stdout ----
Error: Internal("Expected a simplified result, but none was found")


failures:
    cases::roundtrip_logical_plan::roundtrip_literal_list
    cases::roundtrip_logical_plan::roundtrip_values

test result: FAILED. 133 passed; 2 failed; 7 ignored; 0 measured; 0 filtered out; finished in 0.15s

error: test failed, to rerun pass `-p datafusion-substrait --test substrait_integration`

Expected behavior

I expect

1. the tests to pass
2. These tests are run as part of CI

Additional context

No response

[alamb]

It would be sweet if someone could git bisect and figure out when these started failing

[Blizzara]

Hmm, the two tests are failing for me locally as well. However they are run in CI, and there they pass. Looking at the commit you linked for example (but current head of main has the same), https://github.com/apache/datafusion/actions/runs/12413804942/job/34656476010:

     Running tests/substrait_integration.rs (target/debug/deps/substrait_integration-3d7ea520729be616)

running 142 tests
test cases::consumer_integration::tests::tpch_test_03 ... ok
..
test cases::roundtrip_logical_plan::roundtrip_literal_list ... ok
..
test cases::roundtrip_logical_plan::roundtrip_values ... ok
..

test result: ok. 135 passed; 0 failed; 7 ignored; 0 measured; 0 filtered out; finished in 1.51s

vs locally I get same as you:

failures:
    cases::roundtrip_logical_plan::roundtrip_literal_list
    cases::roundtrip_logical_plan::roundtrip_values

test result: FAILED. 133 passed; 2 failed; 7 ignored; 0 measured; 0 filtered out; finished in 0.27s

[Blizzara]

bisect lead to 11d49b4. Specifically, this change: https://github.com/apache/datafusion/pull/13594/files#diff-d195b6dfaaed44b9828e145dc50c075c77b7faf8f44783ca5e6eda2c617af928L39