Support unicode character for initcap function
#13752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tai Le Manh <[email protected]>
github-actions
bot
added
the
documentation
2010YOUY01
approved these changes
Dec 14, 2024
| @@ -74,7 +76,7 @@ impl ScalarUDFImpl for InitcapFunc { | |||
| DataType::LargeUtf8 => make_scalar_function(initcap::<i64>, vec![])(args), | |||
| DataType::Utf8View => make_scalar_function(initcap_utf8view, vec![])(args), | |||
| other => { | |||
| exec_err!("Unsupported data type {other:?} for function initcap") | |||
| exec_err!("Unsupported data type {other:?} for function `initcap`") | |||
There was a problem hiding this comment.
Suggested change
| exec_err!("Unsupported data type {other:?} for function `initcap`") | |
| internal_err!("Unsupported data type {other:?} for function `initcap`") |
Incompatible arg should be checked during planning before, thus here is unreachable, and we can use internal_err to indicate a potential bug if it's executed
There was a problem hiding this comment.
@2010YOUY01 Thanks for reviewing,
Incompatible arg should be checked during planning before, thus here is unreachable, and we can use internal_err to indicate a potential bug if it's executed
Make sense to me👍
| @@ -460,7 +460,7 @@ Andrew Datafusion📊🔥 | |||
| Xiangpeng Datafusion数据融合 | |||
| Raphael Datafusionдатафусион | |||
| Under_Score Un Iść Core | |||
| Percent Pan Tadeusz Ma Iść W KąT | |||
| Percent Pan Tadeusz Ma Iść W Kąt | |||
There was a problem hiding this comment.
I've checked and this result is compatible with PostgreSQL
goldmedal
approved these changes
Dec 17, 2024
| @@ -213,7 +243,7 @@ mod tests { | |||
| Ok(Some("Hi Thomas")), | |||
| &str, | |||
| Utf8, | |||
| StringArray | |||
| StringViewArray | |||
Signed-off-by: Tai Le Manh <[email protected]>
tlm365
force-pushed
the
improve_initcap
branch
from
dd5b400 to
1064aa0
Compare
goldmedal
approved these changes
Dec 22, 2024
|
Thanks @tlm365 and @2010YOUY01 for reviewing |
zhuqi-lucas
pushed a commit
to zhuqi-lucas/arrow-datafusion
that referenced
this pull request
Dec 23, 2024
* Support unicode character for 'initcap' function Signed-off-by: Tai Le Manh <[email protected]> * Update unit tests * Fix clippy warning * Update sqllogictests - initcap * Update scalar_functions.md docs * Add suggestions change Signed-off-by: Tai Le Manh <[email protected]> --------- Signed-off-by: Tai Le Manh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13711.
Rationale for this change
What changes are included in this PR?
initcapfunction.initcapfromstringmodule tounicodemodule.Are these changes tested?
Yes, unit tests are included.
Are there any user-facing changes?
Yes.
api change.