Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initcap function expected return type does not match actual #13907

Closed
timsaucer opened this issue Dec 26, 2024 · 0 comments · Fixed by #13909
Closed

initcap function expected return type does not match actual #13907

timsaucer opened this issue Dec 26, 2024 · 0 comments · Fixed by #13909
Labels
bug Something isn't working

Comments

@timsaucer
Copy link
Contributor

Describe the bug

initcap was updated in this PR: #13752

InitcapFunc is reporting that the return type will be Utf8 but if the argument is an Utf8View then the actual returned values are also Utf8View (as I would expect) so we have a difference between the expected and returned types. I think this is a very easy fix.

On part that I could use some help with from someone more experienced with the Utf8View is this: in get_optimal_return_type macro we state that DataType::Utf8View has an optimal return type of of Utf8 during the macro invocation. Is this the best type? Why would we not want to return a Utf8View?

To Reproduce

Call initcap with a Utf8View argument.

Expected behavior

No error. Currently I get this error:

Exception: Arrow error: Invalid argument error: column types must match schema types, expected Utf8 but found Utf8View at column index 0

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant