Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move optimizer integration tests to core_integration #11830

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 5, 2024

Which issue does this PR close?

Follow up #11798
Part of #11502

Rationale for this change

@Weijun-H and I are working to prepare to move all the physical optimizer rules
into a new crate, so ensuring the existing code has a good pattern to follow is
important

What changes are included in this PR?

  1. Leave a comment with a pointer to the new test
  2. Move the tests for aggregate_statistics into a new module (so as we port the other passes, they will go into their own modules too)

Are these changes tested?

Yes, by CI

The optimizer tests can now be run like

cargo test --test core_integration -- optimizer

Are there any user-facing changes?

No

@github-actions github-actions bot added logical-expr Logical plan and expressions core Core DataFusion crate labels Aug 5, 2024
@alamb alamb force-pushed the move-aggregate-statistics-to-datafusion-physical-optimizer branch from 3e8d99a to 5b46597 Compare August 5, 2024 20:23
@github-actions github-actions bot removed the logical-expr Logical plan and expressions label Aug 5, 2024
Copy link
Member

@lewiszlw lewiszlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Thanks!
Verified these tests are run as part of CI.

@lewiszlw lewiszlw merged commit 537774e into apache:main Aug 6, 2024
24 checks passed
@alamb alamb deleted the move-aggregate-statistics-to-datafusion-physical-optimizer branch August 6, 2024 10:31
@alamb
Copy link
Contributor Author

alamb commented Aug 6, 2024

Thank @lewiszlw !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants