-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPIC] Extract remaining physical optimizer out of core #11502
Comments
@jayzhan211 @lewiszlw How do we plan on moving the rest of the functions. If we move the tests separately many of the tests depend on the traits in the functions that are being moved. Due to this it would make sense to import together, but then problems with the datasource and other util dependencies will pop up again. Do you guys have any solutions in mind? |
We may need to move We probably need to revisit this #10782 |
Try to move optimization that doesn't have datasource dependency like These are good first issues
Require datasource
If we only need datasource in test, leave the test in core |
@jayzhan211 Would you like to open a ticket for moving datasource out of core, so others are more aware of this transition? |
Not sure how do achieve this yet, the high level idea is tracked in #10782 |
take |
Is your feature request related to a problem or challenge?
Given the research from #10782, we need to pull out physical optimizer first before extracting catalog.
Describe the solution you'd like
Pull physical optimizer rules to
datafusion-physical-optimizer
.There are some tests that have dependencies on
datasource
, which they are not possible to move out of core at this moment. We may need to leave those tests inside core for now.datafusion-physical-optimizer
crate #11507Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: