Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#33145 cache namespace string key in FlinkStateInternals #33146

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

je-ik
Copy link
Contributor

@je-ik je-ik commented Nov 18, 2024

Fixes #33145


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@je-ik
Copy link
Contributor Author

je-ik commented Nov 18, 2024

R: @Abacn @kennknowles

Would you have time to review please? The test failures seem unrelated to this PR.

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn
Copy link
Contributor

Abacn commented Nov 18, 2024

Thanks, just one question - now .stringKey is resolved earlier (in constructor) instead of in method calls. Is stringKey guaranteed to be available at that stage?

@je-ik
Copy link
Contributor Author

je-ik commented Nov 19, 2024

Thanks, just one question - now .stringKey is resolved earlier (in constructor) instead of in method calls. Is stringKey guaranteed to be available at that stage?

This is why I made WindowNamespace immutable. Therefore yes, it should be available and constant for the whole lifecycle of the namespace.

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@je-ik je-ik force-pushed the 33145-cache-string-key branch from d740367 to e91c46c Compare November 20, 2024 07:13
@je-ik je-ik merged commit 225b252 into apache:master Nov 20, 2024
29 of 30 checks passed
@je-ik je-ik deleted the 33145-cache-string-key branch November 20, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: [flink] reuse StateNamespace#stringKey in state access
2 participants