Skip to content

Commit

Permalink
Merge pull request #33146: #33145 cache namespace string key in Flink…
Browse files Browse the repository at this point in the history
…StateInternals
  • Loading branch information
je-ik authored Nov 20, 2024
2 parents 97de2ae + e91c46c commit 225b252
Show file tree
Hide file tree
Showing 4 changed files with 64 additions and 69 deletions.
4 changes: 4 additions & 0 deletions .github/trigger_files/beam_PostCommit_Java_Nexmark_Flink.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run",
"runFor": "#33146"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run",
"https://github.com/apache/beam/pull/31156": "noting that PR #31156 should run this test",
"https://github.com/apache/beam/pull/32648": "testing addition of Flink 1.19 support"
"runFor": "#33146"
}
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ public void appendTo(Appendable sb) throws IOException {
/** {@link StateNamespace} that is scoped to a specific window. */
public static class WindowNamespace<W extends BoundedWindow> implements StateNamespace {

private Coder<W> windowCoder;
private W window;
private final Coder<W> windowCoder;
private final W window;

private WindowNamespace(Coder<W> windowCoder, W window) {
this.windowCoder = windowCoder;
Expand Down
Loading

0 comments on commit 225b252

Please sign in to comment.