Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the tox and pyproject settings for numpy 2 #32745

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

liferoad
Copy link
Collaborator

Addresses #32681 and fixes the failed tests in. https://github.com/apache/beam/actions/runs/11278619395/job/31367491096


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@liferoad liferoad requested a review from tvalentyn October 10, 2024 19:40
@liferoad liferoad changed the title fixed the tox and pyproject settings for numpy 2 Fixed the tox and pyproject settings for numpy 2 Oct 10, 2024
@liferoad liferoad mentioned this pull request Oct 10, 2024
3 tasks
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.91%. Comparing base (02e0b3a) to head (d629485).
Report is 35 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #32745      +/-   ##
============================================
+ Coverage     58.84%   58.91%   +0.06%     
  Complexity     3091     3091              
============================================
  Files          1130     1130              
  Lines        174103   174399     +296     
  Branches       3312     3312              
============================================
+ Hits         102451   102747     +296     
  Misses        68326    68326              
  Partials       3326     3326              
Flag Coverage Δ
python 81.48% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liferoad liferoad merged commit ae56318 into apache:master Oct 11, 2024
101 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants