Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the retry order for test_big_query_write_temp_table_append_schema_update #31407

Merged
merged 4 commits into from
May 27, 2024

Conversation

liferoad
Copy link
Collaborator

@liferoad liferoad commented May 25, 2024

Addresses #30513.

After #31364 is merged, we started seeing this:


=================================== FAILURES =================================== |  
-- | --
  | �[31m�[1m_ BigQueryWriteIntegrationTests.test_big_query_write_temp_table_append_schema_update _�[0m |  
  | [gw5] linux -- Python 3.10.14 /runner/_work/beam/beam/build/gradleenv/417525523/bin/python3.10 |  
  |   |  
  | args = (<apache_beam.io.gcp.bigquery_write_it_test.BigQueryWriteIntegrationTests testMethod=test_big_query_write_temp_table_append_schema_update>,) |  
  | kw = {} |  
  |   |  
  | @functools.wraps( |  
  | f, functools.WRAPPER_ASSIGNMENTS + ("__defaults__", "__kwdefaults__") |  
  | ) |  
  | def wrapped_f(*args: t.Any, **kw: t.Any) -> t.Any: |  
  | >       return self(f, *args, **kw) |  
  |   |  
  | �[1m�[31m../../build/gradleenv/417525523/lib/python3.10/site-packages/tenacity/__init__.py�[0m:330: |  
  | _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ |  
  | �[1m�[31m../../build/gradleenv/417525523/lib/python3.10/site-packages/tenacity/__init__.py�[0m:467: in __call__ |  
  | do = self.iter(retry_state=retry_state) |  
  | �[1m�[31m../../build/gradleenv/417525523/lib/python3.10/site-packages/tenacity/__init__.py�[0m:368: in iter |  
  | result = action(retry_state) |  
  | �[1m�[31m../../build/gradleenv/417525523/lib/python3.10/site-packages/tenacity/__init__.py�[0m:410: in exc_check |  
  | raise retry_exc.reraise() |  
  | �[1m�[31m../../build/gradleenv/417525523/lib/python3.10/site-packages/tenacity/__init__.py�[0m:183: in reraise |  
  | raise self.last_attempt.result() |  
  | �[1m�[31m/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/concurrent/futures/_base.py�[0m:451: in result |  
  | return self.__get_result() |  
  | �[1m�[31m/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/concurrent/futures/_base.py�[0m:403: in __get_result |  
  | raise self._exception

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ |  
-- | --
  |   |  
  | self = <Retrying object at 0x7e82b58ae410 (stop=<tenacity.stop.stop_after_attempt object at 0x7e82b58ae350>, wait=<tenacity.w...0x7e82b58ad690>, before=<function before_nothing at 0x7e82b5896170>, after=<function after_nothing at 0x7e82b5896dd0>)> |  
  | fn = None |  
  | args = (<apache_beam.io.gcp.bigquery_write_it_test.BigQueryWriteIntegrationTests testMethod=test_big_query_write_temp_table_append_schema_update>,) |  
  | kwargs = {} |  
  | retry_state = <RetryCallState 139099832550016: attempt #3; slept for 0.0; last result: failed (TypeError 'NoneType' object is not callable)> |  
  | do = <tenacity.DoAttempt object at 0x7e82b41bb940> |  
  |   |  
  | def __call__( |  
  | self, |  
  | fn: t.Callable[..., WrappedFnReturnT], |  
  | *args: t.Any, |  
  | **kwargs: t.Any, |  
  | ) -> WrappedFnReturnT: |  
  | self.begin() |  
  |   |  
  | retry_state = RetryCallState(retry_object=self, fn=fn, args=args, kwargs=kwargs) |  
  | while True: |  
  | do = self.iter(retry_state=retry_state) |  
  | if isinstance(do, DoAttempt): |  
  | try: |  
  | >                   result = fn(*args, **kwargs) |  
  | �[1m�[31mE                   TypeError: 'NoneType' object is not callable�[0m |  
  |   |  
  | �[1m�[31m../../build/gradleenv/417525523/lib/python3.10/site-packages/tenacity/__init__.py�[0m:470: TypeError



https://ge.apache.org/s/t3t76xr2mbgdo/console-log/task/:sdks:python:test-suites:direct:py310:postCommitIT?anchor=203&page=1

I suspect the retry order might cause this issue.

I also fixed the ML test issues.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@liferoad
Copy link
Collaborator Author

@tvalentyn not sure if you can trigger the python postcommits with my PR. Now they are broken due to this retry: https://github.com/apache/beam/actions/runs/9235128248

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn tvalentyn merged commit 2719ca7 into apache:master May 27, 2024
89 checks passed
@tvalentyn
Copy link
Contributor

python postcommits with this PR in flight: https://github.com/apache/beam/actions/runs/9258555564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants