-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retry test_big_query_write_temp_table_append_schema_update up to 3 times #31364
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
PTAL at my comment in 0b617e0#r1598786964 |
Got it. I will follow #31247. |
PTAL at PreCommit Python Lint / beam_PreCommit_PythonLint (Run PythonLint PreCommit) (pull_request_target) Failing after 16m |
@liferoad could you please add details to the PR description about the nature of flakiness in case someone looks up this PR to understand why we aded it? Thanks! |
More details are in the closed PR, which is in the description, :) |
updated the descriptions with more details now |
Addresses #30513.
Following #31350, retry the entire test for now.
For this test:
test_big_query_write_insert_non_transient_api_call_error
, we occasionally see this error:The reason is not clear but the BQ copy job is already done although the error could be retried. To really retry this, we need to retry the entire copy job. Given
STREAMING_INSERTS
is not recommended any more, we decided to just retry the test for now.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.