Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-2.55] Cherry-pick #30648 into release branch #30664

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Mar 18, 2024

This reverts commit ffe2dba.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Mar 18, 2024

R: @arvindram03

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn Abacn added this to the 2.55.0 Release milestone Mar 18, 2024
@Abacn
Copy link
Contributor Author

Abacn commented Mar 18, 2024

R: @arunpandianp

@Abacn
Copy link
Contributor Author

Abacn commented Mar 18, 2024

Flaky test in dataflow-worker:

testDoFnActiveMessageMetadataReportedOnHeartbeat failed indexOutofBound

testDoFnActiveMessageMetadataReportedOnHeartbeat[1: [streamingEngine=true]] (org.apache.beam.runners.dataflow.worker.StreamingDataflowWorkerTest) failed
runners/google-cloud-dataflow-java/worker/build/test-results/test/TEST-org.apache.beam.runners.dataflow.worker.StreamingDataflowWorkerTest.xml [took 2s]
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
	at java.util.ArrayList.rangeCheck(ArrayList.java:659)
	at java.util.ArrayList.get(ArrayList.java:435)
	at java.util.Collections$UnmodifiableList.get(Collections.java:1311)
	at org.apache.beam.runners.dataflow.worker.windmill.Windmill$ComputationHeartbeatRequest.getHeartbeatRequests(Windmill.java:62820)
	at org.apache.beam.runners.dataflow.worker.StreamingDataflowWorkerTest.testDoFnActiveMessageMetadataReportedOnHeartbeat(StreamingDataflowWorkerTest.java:3681)
	...

@Abacn
Copy link
Contributor Author

Abacn commented Mar 18, 2024

known flaky test:

testInvalidRecordReceived (org.apache.beam.sdk.io.gcp.spanner.changestreams.SpannerChangeStreamErrorTest) failed
Expected: (an instance of com.google.cloud.spanner.SpannerException and exception with message a string containing "DEADLINE_EXCEEDED")
     but: an instance of com.google.cloud.spanner.SpannerException <java.lang.AssertionError: 
Expected: <0>
     but: was <7>> is a java.lang.AssertionError
Stacktrace was: java.lang.AssertionError: 
Expected: <0>
     but: was <7>

@Abacn
Copy link
Contributor Author

Abacn commented Mar 18, 2024

Different tests failing on retry:

testRampupThrottler (org.apache.beam.sdk.io.gcp.datastore.RampupThrottlingFnTest) failed

merging for now

@Abacn Abacn merged commit 0dc330e into apache:release-2.55.0 Mar 18, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants