Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repeated test scenarios. #28669

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Remove repeated test scenarios. #28669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eb0394
Remove repeated test scenarios.
tvalentyn Sep 26, 2023
f50a342
Merge branch 'master' into thin_vc
tvalentyn Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions sdks/python/apache_beam/examples/wordcount_it_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ class WordCountIT(unittest.TestCase):
DEFAULT_CHECKSUM = '33535a832b7db6d78389759577d4ff495980b9c0'

@pytest.mark.it_postcommit
@pytest.mark.it_validatescontainer
def test_wordcount_it(self):
self._run_wordcount_it(wordcount.run)

Expand Down Expand Up @@ -89,11 +90,6 @@ def test_wordcount_impersonation_it(self):
with auth._Credentials._credentials_lock:
auth._Credentials._credentials_init = False

@pytest.mark.it_postcommit
@pytest.mark.it_validatescontainer
def test_wordcount_fnapi_it(self):
self._run_wordcount_it(wordcount.run, experiment='beam_fn_api')

@pytest.mark.it_validatescontainer
def test_wordcount_it_with_prebuilt_sdk_container_local_docker(self):
self._run_wordcount_it(
Expand All @@ -108,10 +104,6 @@ def test_wordcount_it_with_prebuilt_sdk_container_cloud_build(self):
experiment='beam_fn_api',
prebuild_sdk_container_engine='cloud_build')

@pytest.mark.it_validatescontainer
def test_wordcount_it_with_use_sibling_sdk_workers(self):
self._run_wordcount_it(wordcount.run, experiment='use_sibling_sdk_workers')

def _run_wordcount_it(self, run_wordcount, **opts):
test_pipeline = TestPipeline(is_integration_test=True)
extra_opts = {}
Expand Down
10 changes: 0 additions & 10 deletions sdks/python/apache_beam/runners/dataflow/dataflow_exercise_metrics_pipeline_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,6 @@ def test_metrics_it(self):
dataflow_exercise_metrics_pipeline.metric_matchers())
self.assertFalse(errors, str(errors))

@pytest.mark.it_postcommit
@pytest.mark.it_validatescontainer
@unittest.skip('https://github.com/apache/beam/issues/22605')
def test_metrics_fnapi_it(self):
result = self.run_pipeline(experiment='beam_fn_api')
errors = metric_result_matchers.verify_all(
result.metrics().all_metrics(),
dataflow_exercise_metrics_pipeline.metric_matchers())
self.assertFalse(errors, str(errors))


if __name__ == '__main__':
unittest.main()
Loading