Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repeated test scenarios. #28669

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Remove repeated test scenarios. #28669

merged 2 commits into from
Sep 28, 2023

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Sep 26, 2023

These scenarios are implicitly repeated in other tests.

@tvalentyn
Copy link
Contributor Author

R: @damccorm

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #28669 (f50a342) into master (57954bd) will increase coverage by 0.09%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28669      +/-   ##
==========================================
+ Coverage   71.97%   72.07%   +0.09%     
==========================================
  Files         680      679       -1     
  Lines      100163    99994     -169     
==========================================
- Hits        72091    72068      -23     
+ Misses      26497    26345     -152     
- Partials     1575     1581       +6     
Flag Coverage Δ
python 82.53% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn tvalentyn merged commit 2d0a52f into apache:master Sep 28, 2023
77 checks passed
@tvalentyn tvalentyn deleted the thin_vc branch September 28, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants