Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go SDK]: Retrieve file size in CreateInitialRestriction in textio.Read #25535

Merged
merged 2 commits into from
Feb 19, 2023

Conversation

johannaojeling
Copy link
Contributor

Fixes #25532 and refactors textio.Read to retrieve the file's size in readFn.CreateInitialRestriction instead of in a separate DoFn.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@johannaojeling johannaojeling changed the title Retrieve file size in CreateInitialRestriction in textio.Read [Go SDK]: Retrieve file size in CreateInitialRestriction in textio.Read Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #25535 (9867810) into master (977e531) will decrease coverage by 0.01%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master   #25535      +/-   ##
==========================================
- Coverage   72.66%   72.66%   -0.01%     
==========================================
  Files         759      759              
  Lines      100689   100685       -4     
==========================================
- Hits        73168    73160       -8     
- Misses      26112    26116       +4     
  Partials     1409     1409              
Flag Coverage Δ
go 52.11% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/io/textio/textio.go 54.21% <62.50%> (-0.95%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.49% <0.00%> (-0.64%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck for label go.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lostluck
Copy link
Contributor

Run Go PostCommit

// error return values, this can be done in readSdfFn.CreateInitialRestriction.
func sizeFn(ctx context.Context, filename string) (string, int64, error) {
// readFn reads individual lines from a text file, given a filename and a
// size in bytes for that file. Implemented as an SDF to allow splitting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it no longer relies on an input size in bytes. We can to remove that part of the comment now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the comment update!

Thank you very kindly!

@lostluck lostluck merged commit d652d05 into apache:master Feb 19, 2023
@johannaojeling johannaojeling deleted the refactor/textio-read branch February 21, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task][Go SDK]: Use context param and error return value in textio.Read SDF
2 participants