Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task][Go SDK]: Use context param and error return value in textio.Read SDF #25532

Closed
1 of 15 tasks
johannaojeling opened this issue Feb 17, 2023 · 1 comment · Fixed by #25535
Closed
1 of 15 tasks

[Task][Go SDK]: Use context param and error return value in textio.Read SDF #25532

johannaojeling opened this issue Feb 17, 2023 · 1 comment · Fixed by #25535
Labels
awaiting triage task
Milestone
2.46.0 Release

Comments

@johannaojeling
Copy link
Contributor

What needs to happen?

There is a TODO in textio.Read to retrieve a file's size in readFn.CreateInitialRestriction instead of in sizeFn once SDF methods support a context.Context parameter and an error return value, which has been added as of #25437.

Issue Priority

Priority: 2 (default / most normal work should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@johannaojeling
Copy link
Contributor Author

.take-issue

@johannaojeling johannaojeling mentioned this issue Feb 17, 2023
Merged
3 tasks
@github-actions github-actions bot added this to the 2.46.0 Release milestone Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting triage task
Projects
None yet
Milestone
2.46.0 Release
Development

Successfully merging a pull request may close this issue.

[Go SDK]: Retrieve file size in CreateInitialRestriction in textio.Read johannaojeling/beam
1 participant
@johannaojeling