Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#24789][prism] add preprocessor and test #25520

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

lostluck
Copy link
Contributor

Adds the handler for the graph pre-processor.

For Prism's initial implementation, it produces single transform stages, so no fusion.

See #24789.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@lostluck
Copy link
Contributor Author

R: @riteshghorse

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #25520 (7fd87e4) into master (6e08092) will decrease coverage by 0.15%.
The diff coverage is 63.10%.

@@            Coverage Diff             @@
##           master   #25520      +/-   ##
==========================================
- Coverage   72.77%   72.62%   -0.15%     
==========================================
  Files         749      759      +10     
  Lines       99434   100638    +1204     
==========================================
+ Hits        72362    73092     +730     
- Misses      25709    26135     +426     
- Partials     1363     1411      +48     
Flag Coverage Δ
go 52.19% <63.10%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...o/pkg/beam/runners/prism/internal/config/config.go 94.73% <ø> (ø)
...o/pkg/beam/core/runtime/exec/sdf_invokers_arity.go 31.91% <31.91%> (ø)
sdks/go/pkg/beam/core/runtime/exec/sdf.go 66.12% <49.38%> (-4.89%) ⬇️
...beam/runners/prism/internal/jobservices/metrics.go 70.83% <70.83%> (ø)
...s/go/pkg/beam/runners/prism/internal/preprocess.go 81.94% <81.94%> (ø)
sdks/go/pkg/beam/core/runtime/exec/sdf_invokers.go 76.30% <86.53%> (+6.12%) ⬆️
sdks/go/pkg/beam/core/graph/fn.go 85.11% <96.77%> (+0.43%) ⬆️
sdks/go/pkg/beam/core/runtime/exec/datasource.go 68.93% <100.00%> (ø)
sdks/go/pkg/beam/io/mongodbio/read.go 9.03% <0.00%> (-21.94%) ⬇️
sdks/go/pkg/beam/io/mongodbio/coder.go 83.33% <0.00%> (-16.67%) ⬇️
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lostluck
Copy link
Contributor Author

The lack of regular updates this week or with how codcovv3 is configured is messing with the coverage numbers. Even according to the bot's output, the non-test file is 90+% covered.

@lostluck
Copy link
Contributor Author

R: @johannaojeling

Mostly just in case you're interested.

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@johannaojeling johannaojeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some small suggestions

}
}

// transformPreparer is an interface for handling different urns in the prepropcessor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// transformPreparer is an interface for handling different urns in the prepropcessor
// transformPreparer is an interface for handling different urns in the preprocessor

// transformPreparer is an interface for handling different urns in the prepropcessor
// largely for exchanging transforms for others, to be added to the complete set of
// components in the pipeline.
type transformPreparer interface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of code organization, it may read better if the transformPreparer type definition is moved above the preprocessor, so that the preprocessor type definition and its related functions/methods are grouped together?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! Thanks. I do prefer having things pre-declared when a different order doesn't dramatically improve readability.

sdks/go/pkg/beam/runners/prism/internal/preprocess.go Outdated Show resolved Hide resolved
@lostluck lostluck merged commit 6667eb4 into apache:master Feb 20, 2023
@lostluck lostluck deleted the prism-preprocess branch February 21, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants