Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go SDK] minor error handling fixes #25555

Merged
merged 1 commit into from
Feb 20, 2023
Merged

[Go SDK] minor error handling fixes #25555

merged 1 commit into from
Feb 20, 2023

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Feb 20, 2023

Fix SDF error output, and fix coder printout in exec.DataSink.

Found in developing estimated watermark handling for Prism (See #24789).


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the go label Feb 20, 2023
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #25555 (8efbc1d) into master (6e08092) will decrease coverage by 0.16%.
The diff coverage is 61.25%.

@@            Coverage Diff             @@
##           master   #25555      +/-   ##
==========================================
- Coverage   72.77%   72.61%   -0.16%     
==========================================
  Files         749      758       +9     
  Lines       99434   100566    +1132     
==========================================
+ Hits        72362    73030     +668     
- Misses      25709    26127     +418     
- Partials     1363     1409      +46     
Flag Coverage Δ
go 52.11% <61.25%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/runtime/exec/datasink.go 0.00% <0.00%> (ø)
...o/pkg/beam/runners/prism/internal/config/config.go 94.73% <ø> (ø)
...o/pkg/beam/core/runtime/exec/sdf_invokers_arity.go 31.91% <31.91%> (ø)
sdks/go/pkg/beam/core/runtime/exec/sdf.go 66.12% <49.38%> (-4.89%) ⬇️
...beam/runners/prism/internal/jobservices/metrics.go 70.83% <70.83%> (ø)
sdks/go/pkg/beam/core/runtime/exec/sdf_invokers.go 76.30% <86.53%> (+6.12%) ⬆️
sdks/go/pkg/beam/core/graph/fn.go 85.11% <95.23%> (+0.43%) ⬆️
sdks/go/pkg/beam/core/runtime/exec/datasource.go 68.93% <100.00%> (ø)
sdks/go/pkg/beam/io/mongodbio/read.go 9.03% <0.00%> (-21.94%) ⬇️
sdks/go/pkg/beam/io/mongodbio/coder.go 83.33% <0.00%> (-16.67%) ⬇️
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey jrmccluskey merged commit 108d097 into master Feb 20, 2023
ruslan-ikhsan pushed a commit to akvelon/beam that referenced this pull request Mar 10, 2023
@lostluck lostluck deleted the minorFixes branch April 12, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants