Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python 3.6 references #25445

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Remove python 3.6 references #25445

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad1e22f
Remove python 3.6 references
AnandInguva Feb 13, 2023
d53518b
Apply suggestions from code review
AnandInguva Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .test-infra/tools/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ Example:
- Original

```bash
python_versions_arr=("3.6.13" "3.7.10" "3.8.9" "3.9.4")
python_versions_arr=("3.7.16" "3.8.16" "3.9.16" "3.10.10")
AnandInguva marked this conversation as resolved.
Show resolved Hide resolved
```

- Change

```bash
python_versions_arr=("3.6.13" "3.7.10" "3.9.0" "3.10.2")
python_versions_arr=("3.7.10" "3.9.0" "3.10.2")
AnandInguva marked this conversation as resolved.
Show resolved Hide resolved
```
2 changes: 1 addition & 1 deletion .test-infra/tools/python_installer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
set -euo pipefail

# Variable containing the python versions to install
python_versions_arr=("3.8.9" "3.6.13" "3.7.10" "3.9.4" "3.10.1")
python_versions_arr=("3.7.16" "3.8.16" "3.9.16" "3.10.10")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whichever version is in the beginning will be the default Python intepreter (e.g. when one runs python3). This line will change default from 3.8 to 3.7. Let's keep it 3.8 or change to 3.9 / 3.10.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it. PTAL @tvalentyn

AnandInguva marked this conversation as resolved.
Show resolved Hide resolved

# Install pyenv dependencies.
pyenv_dep(){
Expand Down
2 changes: 1 addition & 1 deletion sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@

_LOGGER = logging.getLogger(__name__)

_PYTHON_VERSIONS_SUPPORTED_BY_DATAFLOW = ['3.6', '3.7', '3.8', '3.9', '3.10']
_PYTHON_VERSIONS_SUPPORTED_BY_DATAFLOW = ['3.7', '3.8', '3.9', '3.10']


class Step(object):
Expand Down
2 changes: 1 addition & 1 deletion website/www/site/content/en/get-started/quickstart-py.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ If you're interested in contributing to the Apache Beam Python codebase, see the

{{< toc >}}

The Python SDK supports Python 3.6, 3.7, and 3.8. Beam 2.24.0 was the last release with support for Python 2.7 and 3.5.
The Python SDK supports Python 3.7, 3.8, 3.9 and 3.10. Beam 2.38.0 was the last release with support for Python 3.6.

## Set up your environment

Expand Down