Remove python 3.6 references #25445
Merged
Remove python 3.6 references #25445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #25445 +/- ##
==========================================
- Coverage 72.87% 72.82% -0.05%
==========================================
Files 750 751 +1
Lines 99501 99659 +158
==========================================
+ Hits 72509 72576 +67
- Misses 25624 25715 +91
Partials 1368 1368
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Run Python Dataflow ValidatesRunner |
tvalentyn
reviewed
Feb 13, 2023
| @@ -20,7 +20,7 @@ | |||
| set -euo pipefail | |||
|
|
|||
| # Variable containing the python versions to install | |||
| python_versions_arr=("3.8.9" "3.6.13" "3.7.10" "3.9.4" "3.10.1") | |||
| python_versions_arr=("3.7.16" "3.8.16" "3.9.16" "3.10.10") | |||
There was a problem hiding this comment.
whichever version is in the beginning will be the default Python intepreter (e.g. when one runs python3). This line will change default from 3.8 to 3.7. Let's keep it 3.8 or change to 3.9 / 3.10.
There was a problem hiding this comment.
Changed it. PTAL @tvalentyn
AnandInguva
commented
Feb 13, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25002
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.