Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further increase transient expansion service timeout #25176

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jan 25, 2023

Fixes #25110

reverting much of #25111 and #25169 and direct to the actual code path

In #25111 I assumed the cause is that the expansion service needs more time up when there is extra dependency. This is not true. The expansion service is a python interpreter call. It is markedly faster at the second time, which is why there is almost always one test (but not more) fail.

This is also a followup of a paralllel effort #25169

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@Abacn
Copy link
Contributor Author

Abacn commented Jan 25, 2023

R: @chamikaramj

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

@Abacn
Copy link
Contributor Author

Abacn commented Jan 26, 2023

Run XVR_Direct PostCommit

@Abacn
Copy link
Contributor Author

Abacn commented Jan 26, 2023

related test passed. The failing test is a go test github.com/apache/beam/sdks/v2/go/test/integration/io/xlang/debezium not shown in test result. merge for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants