Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default expansion service timeout #25169

Conversation

chamikaramj
Copy link
Contributor

Seems like number of open source runner tests are flaky due to timeout here not being adequate. For example,

https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/3670/testReport/org.apache.beam.sdk.extensions.python/PythonExternalTransformTest/trivialPythonTransform/


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@johnjcasey
Copy link
Contributor

LGTM

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@chamikaramj
Copy link
Contributor Author

Run Java PreCommit

1 similar comment
@chamikaramj
Copy link
Contributor Author

Run Java PreCommit

@chamikaramj
Copy link
Contributor Author

Thanks!

@chamikaramj chamikaramj merged commit 48712b2 into apache:master Jan 25, 2023
@Abacn
Copy link
Contributor

Abacn commented Jan 25, 2023

Noticed the same thing in #25111 actually the code path taking effect is here:

PythonService.waitForPort("localhost", port, timeoutSeconds * 1000);

will create another PR for it

@Abacn
Copy link
Contributor

Abacn commented Jan 25, 2023

opened #25176

@chamikaramj
Copy link
Contributor Author

Yeah, correct. Makes sense to increase the timeout for all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants