Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ToB][Frontend] Gradle tasks for ToB frontend #24919

Merged
merged 6 commits into from
Jan 25, 2023

Conversation

nausharipov
Copy link
Contributor

@nausharipov nausharipov commented Jan 6, 2023

Resolves #24563


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@nausharipov
Copy link
Contributor Author

R: @alexeyinkin

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


doLast {
exec {
// Exact paths instead of '.' so it does not go into playground_components
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete such comments here and in Playground so we can copy tasks between them.


tasks.register("pubGet") {
group = "build"
description = "Get packages for the playground frontend project"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strip project names from descriptions so the same ones can be used for both Playground and ToB.

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #24919 (bb0b08e) into master (95e5391) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24919      +/-   ##
==========================================
+ Coverage   73.07%   73.16%   +0.08%     
==========================================
  Files         735      734       -1     
  Lines       98133    98358     +225     
==========================================
+ Hits        71713    71960     +247     
+ Misses      25061    25038      -23     
- Partials     1359     1360       +1     
Flag Coverage Δ
python 82.76% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/metrics/dumper.go 49.20% <0.00%> (-4.77%) ⬇️
sdks/go/pkg/beam/core/metrics/metrics.go 60.29% <0.00%> (-0.25%) ⬇️
sdks/python/apache_beam/runners/common.py 88.59% <0.00%> (-0.13%) ⬇️
sdks/go/pkg/beam/transforms/sql/sql.go
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.40% <0.00%> (+0.16%) ⬆️
sdks/python/apache_beam/typehints/typehints.py 93.43% <0.00%> (+0.38%) ⬆️
...dks/python/apache_beam/options/pipeline_options.py 96.13% <0.00%> (+2.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@alexeyinkin alexeyinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (internal review).

@nausharipov nausharipov marked this pull request as ready for review January 6, 2023 12:21
@nausharipov
Copy link
Contributor Author

R: @damondouglas

@nausharipov
Copy link
Contributor Author

The README will be updated in a separate task: #25076

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damccorm LGTM

@damccorm damccorm merged commit 72d2776 into apache:master Jan 25, 2023
@nausharipov nausharipov deleted the issue24563_tobf_gradle branch January 25, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Gradle tasks for ToB frontend
4 participants