-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ToB][Frontend] Gradle tasks for ToB frontend #24919
Conversation
R: @alexeyinkin |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
||
doLast { | ||
exec { | ||
// Exact paths instead of '.' so it does not go into playground_components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete such comments here and in Playground so we can copy tasks between them.
|
||
tasks.register("pubGet") { | ||
group = "build" | ||
description = "Get packages for the playground frontend project" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strip project names from descriptions so the same ones can be used for both Playground and ToB.
Codecov Report
@@ Coverage Diff @@
## master #24919 +/- ##
==========================================
+ Coverage 73.07% 73.16% +0.08%
==========================================
Files 735 734 -1
Lines 98133 98358 +225
==========================================
+ Hits 71713 71960 +247
+ Misses 25061 25038 -23
- Partials 1359 1360 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (internal review).
The README will be updated in a separate task: #25076 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damccorm LGTM
Resolves #24563
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.