Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Gradle tasks for ToB frontend #24563

Closed
alexeyinkin opened this issue Dec 7, 2022 · 1 comment · Fixed by #24919
Closed

[Task]: Gradle tasks for ToB frontend #24563

alexeyinkin opened this issue Dec 7, 2022 · 1 comment · Fixed by #24919
Assignees
@nausharipov
Labels
beam-playground P3 task
Milestone
2.46.0 Release

Comments

@alexeyinkin
Copy link
Contributor

What needs to happen?

The tasks should mirror the tasks of Playground frontend. In particular:

  • generate
  • generateCode
  • pubGet
  • format
  • run
  • test
  • precommit
  • cleanFlutter
  • cleanGenerated

Some of the Playground's tasks calls appropriate tasks on playground_components, and this is easy because the latter is a sub-project of the former.

ToB also depends on playground_components, so ToB's tasks should call playground_components's tasks in all the same cases that Playground does. This may be a bit harder because that is not a sub-project anymore.

The Gradle project file for ToB should be in .kts format.

Issue Priority

Priority: 3

Issue Component

Component: beam-playground
@olehborysevych olehborysevych moved this to Todo in Tour of Beam Dec 7, 2022
@nausharipov
Copy link
Contributor

.take-issue

nausharipov pushed a commit to akvelon/beam that referenced this issue Jan 6, 2023
WIP: playground_components works in tour-of-beam only with configureo…
b5482ef 
…ndemand set to false (apache#24563)
nausharipov pushed a commit to akvelon/beam that referenced this issue Jan 6, 2023
added evaluationDependsOn playground_components (apache#24563)
8ac27a1
@nausharipov nausharipov mentioned this issue Jan 6, 2023
Merged
3 tasks
nausharipov pushed a commit to akvelon/beam that referenced this issue Jan 6, 2023
comments (1) (apache#24563)
d6783c3
nausharipov pushed a commit to akvelon/beam that referenced this issue Jan 6, 2023
removed goToContextLine after merge (apache#24563)
6ebe89d
@github-project-automation github-project-automation bot moved this from Todo to Done in Tour of Beam Jan 25, 2023
damccorm pushed a commit that referenced this issue Jan 25, 2023
@nausharipov
[ToB][Frontend] Gradle tasks for ToB frontend (#24919)
72d2776 
* WIP: playground_components works in tour-of-beam only with configureondemand set to false (#24563)

* added evaluationDependsOn playground_components (#24563)

* comments (1) (#24563)

* removed goToContextLine after merge (#24563)

Co-authored-by: darkhan.nausharipov <[email protected]>
@github-actions github-actions bot added this to the 2.46.0 Release milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nausharipov nausharipov

Labels
beam-playground P3 task
Projects
Tour of Beam
Status: Done
Milestone
2.46.0 Release
Development

Successfully merging a pull request may close this issue.

[ToB][Frontend] Gradle tasks for ToB frontend akvelon/beam
2 participants
@nausharipov @alexeyinkin