Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CdapIO] CdapIO and SparkReceiverIO updates #24436

Merged
merged 5 commits into from
Dec 9, 2022
Merged

[CdapIO] CdapIO and SparkReceiverIO updates #24436

merged 5 commits into from
Dec 9, 2022

Conversation

Amar3tto
Copy link
Contributor

@Amar3tto Amar3tto commented Nov 30, 2022 •
edited
Loading

Resolves #24961
Resolves #24960

  • Added pullFrequencySec parameter - delay in seconds between polling for new records updates.
  • Added startOffset parameter - inclusive start offset from which the reading should be started.
  • Refactoring (Plugin, MappingUtils, context classes)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@Amar3tto Amar3tto marked this pull request as ready for review November 30, 2022 18:46
@elizaveta-lomteva elizaveta-lomteva mentioned this pull request Nov 30, 2022
Closed
4 tasks
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kileys for label java.
R: @pabloem for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@AKosolapov
Copy link
Contributor

Run Java PreCommit

@AKosolapov
Copy link
Contributor

Run Java_Examples_Dataflow PreCommit

@elizaveta-lomteva
Copy link
Contributor

Run Java PreCommit

@elizaveta-lomteva
Copy link
Contributor

Run Java_Examples_Dataflow_Java17 PreCommit

@Amar3tto
Copy link
Contributor Author

Amar3tto commented Dec 2, 2022

Run Java PreCommit

1 similar comment
@AKosolapov
Copy link
Contributor

Run Java PreCommit

@elizaveta-lomteva
Copy link
Contributor

R: @aromanenko-dev
R: @johnjcasey
R: @chamikaramj

This is the PR with CDAP and SparkReceiver IOs' changes (related to the comment from the #23501 PR).

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

This was referenced Dec 7, 2022
Merged
Merged
johnjcasey
johnjcasey requested changes Dec 7, 2022
View reviewed changes
.../java/io/cdap/src/main/java/org/apache/beam/sdk/io/cdap/context/FailureCollectorWrapper.java Outdated

// We skip schema field validation errors because they are CDAP oriented and don't affect
// anything in our case
for (Iterator<ValidationFailure> failureIterator = failuresCollection.iterator();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we restructure this loop to not depend on an iterator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Amar3tto Amar3tto mentioned this pull request Dec 8, 2022
Merged
3 tasks
@Amar3tto Amar3tto mentioned this pull request Dec 8, 2022
Merged
3 tasks
@elizaveta-lomteva
Copy link
Contributor

@johnjcasey
All comments have been addressed, thanks!

@johnjcasey johnjcasey merged commit 6db3030 into apache:master Dec 9, 2022
lostluck pushed a commit to lostluck/beam that referenced this pull request Dec 22, 2022
@Amar3tto @lostluck
[CdapIO] CdapIO and SparkReceiverIO updates (apache#24436)
90cf0f1 
* Add pullFrequency and startOffset parameters. Refactoring of Plugin and MappingUtils classes.

* Fix startOffset

* Change dependency configuration

* Add constants in test

* Resolve comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnjcasey johnjcasey johnjcasey approved these changes

Assignees
No one assigned
Labels
io java Next Action: Reviewers
Projects
None yet
Milestone
No milestone
4 participants
@Amar3tto @AKosolapov @elizaveta-lomteva @johnjcasey