-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CdapIO] Add complete examples for CdapIO #23501
Conversation
Run Java_Examples_Dataflow_Java17 PreCommit |
Run Java PreCommit |
1 similar comment
Run Java PreCommit |
Assigning reviewers. If you would like to opt out of this review, comment R: @apilloud for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
e392e6b
to
d340f0e
Compare
Run Java PreCommit |
1 similar comment
Run Java PreCommit |
Run Java PreCommit |
19b22f1
to
70cff05
Compare
Codecov Report
@@ Coverage Diff @@
## master #23501 +/- ##
==========================================
- Coverage 73.31% 73.22% -0.10%
==========================================
Files 714 717 +3
Lines 96418 96932 +514
==========================================
+ Hits 70686 70974 +288
- Misses 24411 24637 +226
Partials 1321 1321
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@chamikaramj @aromanenko-dev @mosche @johnjcasey |
Run Typescript PreCommit |
Run RAT PreCommit |
Run Python PreCommit |
Run Java PreCommit |
Run Java_Spark3_Versions PreCommit |
R: @johnjcasey |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
1 similar comment
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't these examples missing will block CDAP being included the next release. It may be worth splitting this PR into one PR for the IO changes, and one PR for the examples
public class StructuredRecordUtils { | ||
|
||
/** Converts {@link StructuredRecord} to String json-like format. */ | ||
public static String structuredRecordToString(StructuredRecord structuredRecord) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there not a way to do this with json serialization?
* Class for getting a {@link SerializableFunction} that defines how to get record offset for | ||
* different CDAP {@link Plugin} classes. | ||
*/ | ||
public class GetOffsetUtils { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these utility files organized by function, instead of by plugin?
+1 for splitting this huge PR in to multiple PRs for ease of review (may be per example). |
@johnjcasey |
+1 for multiple PRs split by example |
Finished splitting PRs:
|
SparkReceiverIO
andCdapIO
changes:pullFrequencySec
parameter - delay in seconds between polling for new records updates.startOffset
parameter - inclusive start offset from which the reading should be started.Plugin
,MappingUtils
, context classes)Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.