Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get postcommits green and unsickbay go test #24342

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

damccorm
Copy link
Contributor

In #24228 we applied a general fix for some classes of flink failures - this cleans up some previous attempts to work around the issues and unsickbays a go test. I tried applying the same fix to the other flink postcommits and ran into some issues with OOMs (see #24254)

Part of #21094


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@damccorm
Copy link
Contributor Author

Run Go Flink ValidatesRunner

@damccorm
Copy link
Contributor Author

Run Python Examples_Flink

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #24342 (c535153) into master (a04682a) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24342      +/-   ##
==========================================
- Coverage   73.46%   73.37%   -0.10%     
==========================================
  Files         714      717       +3     
  Lines       96497    96850     +353     
==========================================
+ Hits        70896    71061     +165     
- Misses      24279    24467     +188     
  Partials     1322     1322              
Flag Coverage Δ
python 82.99% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
.../python/apache_beam/transforms/periodicsequence.py 97.01% <0.00%> (-1.50%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.50% <0.00%> (-1.27%) ⬇️
...dks/python/apache_beam/options/pipeline_options.py 93.96% <0.00%> (-0.95%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.49% <0.00%> (-0.64%) ⬇️
...ks/python/apache_beam/runners/worker/data_plane.py 87.57% <0.00%> (-0.57%) ⬇️
...ache_beam/runners/portability/local_job_service.py 82.00% <0.00%> (-0.50%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.30% <0.00%> (-0.38%) ⬇️
...on/apache_beam/runners/dataflow/dataflow_runner.py 82.69% <0.00%> (-0.21%) ⬇️
sdks/python/apache_beam/pipeline.py 92.12% <0.00%> (-0.15%) ⬇️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.
R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Go

@damccorm
Copy link
Contributor Author

R: @Abacn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@damccorm damccorm merged commit 6dc4b73 into master Nov 28, 2022
@damccorm damccorm deleted the users/damccorm/flink-postcommits branch November 28, 2022 15:15
ruslan-ikhsan pushed a commit to ruslan-ikhsan/beam that referenced this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants