Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flink XVR tests #24228

Merged
merged 15 commits into from
Nov 18, 2022
Merged

Fix flink XVR tests #24228

merged 15 commits into from
Nov 18, 2022

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Nov 17, 2022 •
edited
Loading

This applies the changes from #17067 to all flink tests that use the flink job server task. This should fix the java.io.IOException: Insufficient number of network buffers: required 17, but only 14 available. The total number of network buffers is currently set to 2048 of 32768 bytes each. You can increase this number by setting the configuration keys 'taskmanager.memory.network.fraction', 'taskmanager.memory.network.min', and 'taskmanager.memory.network.max'. exception

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the infra label Nov 17, 2022
@damccorm
Copy link
Contributor Author

Run Seed Job

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run Seed Job

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run Seed Job

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run Seed Job

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@codecov
Copy link

codecov bot commented Nov 17, 2022 •
edited
Loading

Codecov Report

Merging #24228 (049fabd) into master (755b9c9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24228   +/-   ##
=======================================
  Coverage   73.45%   73.46%           
=======================================
  Files         714      714           
  Lines       96496    96497    +1     
=======================================
+ Hits        70885    70890    +5     
+ Misses      24288    24284    -4     
  Partials     1323     1323
Flag Coverage Δ
python 83.17% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/core.py 92.54% <0.00%> (-0.37%) ⬇️
...pache_beam/runners/interactive/interactive_beam.py 81.70% <0.00%> (ø)
...eam/runners/portability/fn_api_runner/execution.py 93.13% <0.00%> (+0.63%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 91.77% <0.00%> (+1.26%) ⬆️
.../python/apache_beam/transforms/periodicsequence.py 98.50% <0.00%> (+1.49%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 92.85% <0.00%> (+4.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run Seed Job

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run Seed Job

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

damccorm commented Nov 18, 2022 •
edited
Loading

(this version worked, though a different test failed for seemingly unrelated reasons https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink_PR/264/console)


FAIL: TestKafkaIO_BasicReadWrite (0.01s)
08:02:41 panic: 	tried cross-language for beam:transform:org.apache.beam:kafka_write:v1 against localhost:44319 and failed
08:02:41 	expanding external transform
08:02:41 	expanding transform with ExpansionRequest: components:{pcollections:{key:"n4"  value:{unique_name:"n4"  coder_id:"c1@ErKwBRUxvv"  is_bounded:BOUNDED  windowing_strategy_id:"w0@ErKwBRUxvv"}}  windowing_strategies:{key:"w0@ErKwBRUxvv"  value:{window_fn:{urn:"beam:window_fn:global_windows:v1"}  merge_status:NON_MERGING  window_coder_id:"c2@ErKwBRUxvv"  trigger:{default:{}}  accumulation_mode:DISCARDING  output_time:END_OF_WINDOW  closing_behavior:EMIT_IF_NONEMPTY  on_time_behavior:FIRE_IF_NONEMPTY  environment_id:"go"}}  coders:{key:"c0@ErKwBRUxvv"  value:{spec:{urn:"beam:coder:bytes:v1"}}}  coders:{key:"c1@ErKwBRUxvv"  value:{spec:{urn:"beam:coder:kv:v1"}  component_coder_ids:"c0@ErKwBRUxvv"  component_coder_ids:"c0@ErKwBRUxvv"}}  coders:{key:"c2@ErKwBRUxvv"  value:{spec:{urn:"beam:coder:global_window:v1"}}}}  transform:{unique_name:"External"  spec:{urn:"beam:transform:org.apache.beam:kafka_write:v1"  payload:"\n}\n\x1c\n\x0eProducerConfig\x1a\n*\x08\n\x02\x10\x07\x12\x02\x10\x07\n\x0b\n\x05Topic\x1a\x02\x10\x07\n\x13\n\rKeySerializer\x1a\x02\x10\x07\n\x15\n\x0fValueSerializer\x1a\x02\x10\x07\x12$d97fbd8d-dde2-46d8-babd-f5372b6ab5e6\x12\xda\x01\x04\x00\x00\x00\x00\x01\x11bootstrap.servers\x0flocalhost:37919=xlang_kafkaio_basic_test_364cd506-46f5-49dc-aeb4-4f84e1ea3e739org.apache.kafka.common.serialization.ByteArraySerializer9org.apache.kafka.common.serialization.ByteArraySerializer"}  inputs:{key:"i0"  value:"n4"}  environment_id:"go"}  namespace:"ErKwBRUxvv"
08:02:41 expansion failed
08:02:41 	caused by:
08:02:41 rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp 127.0.0.1:44319: connect: connection refused" [recovered]
08:02:41 	panic: 	tried cross-language for beam:transform:org.apache.beam:kafka_write:v1 against localhost:44319 and failed
08:02:41 	expanding external transform
08:02:41 	expanding transform with ExpansionRequest: components:{pcollections:{key:"n4"  value:{unique_name:"n4"  coder_id:"c1@ErKwBRUxvv"  is_bounded:BOUNDED  windowing_strategy_id:"w0@ErKwBRUxvv"}}  windowing_strategies:{key:"w0@ErKwBRUxvv"  value:{window_fn:{urn:"beam:window_fn:global_windows:v1"}  merge_status:NON_MERGING  window_coder_id:"c2@ErKwBRUxvv"  trigger:{default:{}}  accumulation_mode:DISCARDING  output_time:END_OF_WINDOW  closing_behavior:EMIT_IF_NONEMPTY  on_time_behavior:FIRE_IF_NONEMPTY  environment_id:"go"}}  coders:{key:"c0@ErKwBRUxvv"  value:{spec:{urn:"beam:coder:bytes:v1"}}}  coders:{key:"c1@ErKwBRUxvv"  value:{spec:{urn:"beam:coder:kv:v1"}  component_coder_ids:"c0@ErKwBRUxvv"  component_coder_ids:"c0@ErKwBRUxvv"}}  coders:{key:"c2@ErKwBRUxvv"  value:{spec:{urn:"beam:coder:global_window:v1"}}}}  transform:{unique_name:"External"  spec:{urn:"beam:transform:org.apache.beam:kafka_write:v1"  payload:"\n}\n\x1c\n\x0eProducerConfig\x1a\n*\x08\n\x02\x10\x07\x12\x02\x10\x07\n\x0b\n\x05Topic\x1a\x02\x10\x07\n\x13\n\rKeySerializer\x1a\x02\x10\x07\n\x15\n\x0fValueSerializer\x1a\x02\x10\x07\x12$d97fbd8d-dde2-46d8-babd-f5372b6ab5e6\x12\xda\x01\x04\x00\x00\x00\x00\x01\x11bootstrap.servers\x0flocalhost:37919=xlang_kafkaio_basic_test_364cd506-46f5-49dc-aeb4-4f84e1ea3e739org.apache.kafka.common.serialization.ByteArraySerializer9org.apache.kafka.common.serialization.ByteArraySerializer"}  inputs:{key:"i0"  value:"n4"}  environment_id:"go"}  namespace:"ErKwBRUxvv"
08:02:41 expansion failed
08:02:41 	caused by:
08:02:41 rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp 127.0.0.1:44319: connect: connection refused"
08:02:41 
08:02:41 goroutine 11 [running]:
08:02:41 testing.tRunner.func1.2({0xda55a0, 0xc00069ca40})
08:02:41 	/home/jenkins/sdk/go1.19.3/src/testing/testing.go:1396 +0x24e
08:02:41 testing.tRunner.func1()
08:02:41 	/home/jenkins/sdk/go1.19.3/src/testing/testing.go:1399 +0x39f
08:02:41 panic({0xda55a0, 0xc00069ca40})
08:02:41 	/home/jenkins/sdk/go1.19.3/src/runtime/panic.go:884 +0x212
08:02:41 github.com/apache/beam/sdks/v2/go/pkg/beam.CrossLanguage({0xc000489680?, 0xc0004b9c70?}, {0xee06b4, 0x2d}, {0xc00013c6e0?, 0xcfaf20?, 0xc0001b54c0?}, {0xc00048b310, 0xf}, 0xc000169c60, ...)
08:02:41 	/home/jenkins/jenkins-slave/workspace/beam_PostCommit_XVR_Flink_PR/src/sdks/go/pkg/beam/xlang.go:162 +0x136
08:02:41 github.com/apache/beam/sdks/v2/go/pkg/beam/io/xlang/kafkaio.Write({0xc000489420?, 0xc0004b9c70?}, {0xc00048b310, 0xf}, {0xc00048b2d0, 0xf}, {0xc0004b6e80, 0x3d}, {0xc000169e60?}, {0x0, ...})
08:02:41 	/home/jenkins/jenkins-slave/workspace/beam_PostCommit_XVR_Flink_PR/src/sdks/go/pkg/beam/io/xlang/kafkaio/kafka.go:278 +0x4cb
08:02:41 github.com/apache/beam/sdks/v2/go/test/integration/io/xlang/kafka.writeInts({0xc000489400?, 0xc0004b9c70?}, {0xc00048b310, 0xf}, {0xc00048b2d0, 0xf}, {0xc0004b6e80, 0x3d}, {0xc0000f8000, 0x3e8, ...})
08:02:41 	/home/jenkins/jenkins-slave/workspace/beam_PostCommit_XVR_Flink_PR/src/sdks/go/test/integration/io/xlang/kafka/kafka.go:48 +0x24d
08:02:41 github.com/apache/beam/sdks/v2/go/test/integration/io/xlang/kafka.WritePipeline({0xc00048b310, 0xf}, {0xc00048b2d0, 0xf}, {0xc0004b6e80, 0x3d}, {0xc0000f8000, 0x3e8, 0x3e8})
08:02:41 	/home/jenkins/jenkins-slave/workspace/beam_PostCommit_XVR_Flink_PR/src/sdks/go/test/integration/io/xlang/kafka/kafka.go:70 +0x157
08:02:41 github.com/apache/beam/sdks/v2/go/test/integration/io/xlang/kafka.TestKafkaIO_BasicReadWrite(0xc000491860)
08:02:41 	/home/jenkins/jenkins-slave/workspace/beam_PostCommit_XVR_Flink_PR/src/sdks/go/test/integration/io/xlang/kafka/kafka_test.go:61 +0xed
08:02:41 testing.tRunner(0xc000491860, 0xf18ff0)
08:02:41 	/home/jenkins/sdk/go1.19.3/src/testing/testing.go:1446 +0x10b
08:02:41 created by testing.(*T).Run
08:02:41 	/home/jenkins/sdk/go1.19.3/src/testing/testing.go:1493 +0x35f
08:02:41 FAIL	github.com/apache/beam/sdks/v2/go/test/integration/io/xlang/kafka	6.051s

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@github-actions github-actions bot removed the infra label Nov 18, 2022
@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm damccorm marked this pull request as ready for review November 18, 2022 15:56
@damccorm
Copy link
Contributor Author

R: @Abacn

I think this should fix flink postcommits on Go across the board. I'll add a follow up PR to reenable Go tests and remove some of the changes from https://github.com/apache/beam/pull/24159/files once this in in (anything else I'm missing?)

@damccorm damccorm changed the title WIP: Attempt to fix flink XVR tests Fix flink XVR tests Nov 18, 2022
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Abacn
Abacn approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beam_PostCommit_XVR_Flink test passed. LGTM

@damccorm damccorm merged commit 60caac6 into master Nov 18, 2022
@damccorm damccorm deleted the users/damccorm/flinkXVR branch November 18, 2022 16:30
This was referenced Nov 18, 2022
Open
Closed
prodriguezdefino pushed a commit to prodriguezdefino/beam-pabs that referenced this pull request Nov 18, 2022
@damccorm @prodriguezdefino
Fix flink XVR tests (apache#24228)
8cb1ea5 
* WIP: Attempt to fix flink XVR tests

* Add some debugging info

* Fix logging

* Fix pathing

* Disable caching for now

* Try manually setting flink-conf-dir

* Try manually setting flink-conf-dir

* Try setting it in run_job_server

* Clean up method of passing extra args

* Accept additional args in script

* Try more explicit route

* Try more explicit route

* Try to prove this works

* A little indirection

* Fix pathing
@damccorm damccorm mentioned this pull request Nov 23, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abacn Abacn Abacn approved these changes

Assignees
No one assigned
Labels
flink python runners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damccorm @Abacn