-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(BQ Python) Fix streaming with large loads by performing job waits in finish_bundle #23012
Conversation
…copy jobs will provide trigger for delete stage
Waiting for #23011 |
Assigning reviewers. If you would like to opt out of this review, comment R: @pabloem for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
…ing to separate outputs in the same finish_bundle
Codecov Report
@@ Coverage Diff @@
## master #23012 +/- ##
=======================================
Coverage 73.58% 73.59%
=======================================
Files 716 716
Lines 95311 95327 +16
=======================================
+ Hits 70138 70153 +15
- Misses 23877 23878 +1
Partials 1296 1296
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run Python 3.8 PostCommit |
895ce32
to
1e39863
Compare
Streaming FILE_LOADS is currently not working with large loads. After the first load, it lags because
WaitForBQJobs
is only triggered once withbeam.Create([None])
. These changes move the wait into the finish_bundle of its respective step.Note: Streaming with small loads is done in one step and thus was not getting stuck.
Also adding tests that more accurately determine if streaming with batch loads is working.
Needs #23011 to run tests correctly
Fixes #23104