-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(BQ Python) Pass project field from options or parameter when writing with dynamic destinations #23011
(BQ Python) Pass project field from options or parameter when writing with dynamic destinations #23011
Conversation
Run Python 3.8 PostCommit |
Assigning reviewers. If you would like to opt out of this review, comment R: @yeandy for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Run Python 3.8 PostCommit |
Codecov Report
@@ Coverage Diff @@
## master #23011 +/- ##
==========================================
- Coverage 73.66% 73.61% -0.06%
==========================================
Files 713 716 +3
Lines 94970 95228 +258
==========================================
+ Hits 69960 70100 +140
- Misses 23709 23827 +118
Partials 1301 1301
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
b9d4313
to
8b25209
Compare
8b25209
to
7793d7c
Compare
Run Python 3.8 PostCommit |
Run Python 3.8 PostCommit |
R: @johnjcasey |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Run Python 3.8 PostCommit |
Run Python 3.8 PostCommit |
1 similar comment
Run Python 3.8 PostCommit |
Currently dynamic destinations cannot be passed in as
<DATASET>.<TABLE>
. For single destinations, the project ID is added from pipeline options earlier in the workflow. This isn't applied to dynamic destinations because the actual destinations are determined later.These changes will provide the project ID at the moments when they are needed, ie. when submitting:
These changes will also give precedence to the project parameter inReverted this part because it's not backwards compatible.WriteToBigQuery
over the project found in pipeline options. The reasoning is that a user may have one pipeline writing to tables in different projects.