Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[providers-fab/v1-5] Invalidate user session on password reset (#45139) #45185

Merged
merged 6 commits into from
Dec 24, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 23, 2024

session expire on pass change

fix statis checks

add tests (cherry picked from commit cf401c4)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Dec 23, 2024

Same as #45164 but opened from the "apache/airlfow" repository so that after approval I can just push the providers-fab/v1-5 branch to the tip of the approved PR - to keep commit history.

@potiuk potiuk requested a review from amoghrajesh December 23, 2024 17:18
shubhamraj-git and others added 6 commits December 24, 2024 09:09
* session expire on pass change

* fix statis checks

* add tests
(cherry picked from commit cf401c4)

Co-authored-by: Shubham Raj <[email protected]>
* Fixing cli test failure in CI

* review comments

(cherry picked from commit 98e0977)
The 1.1.8 version of msgraph-core is buggy - importing some basic
classes causes import error "ABCMeta" is not subscriptable.

We are removing the version from azure provider dependencies hoping
that it will be fixed in the next version.

microsoftgraph/msgraph-sdk-python-core#781
(cherry picked from commit 3310b86)
This field (`dataplex_transfer_status`) got added in googleapis/google-cloud-python#13277 as part of `google-cloud-datacatalog==3.22.0`

(cherry picked from commit 060f75f)
* fix google datacatalog operator tests

* bump google-cloud-datacatalog

(cherry picked from commit f6bbc63)
The #45139 imported isabs from "airflow.www.app" - but isabs has
been added there fairly recently and it is anyhow stdlib's os.path
isabs - so it should be imported from there.

This breaks fab 1.5.2 backport compatibility tests, so we need to
cherry-pick it there alongside #45139

(cherry picked from commit 7002966)
@potiuk potiuk force-pushed the backport-fab-provider-commit branch from fd3ec48 to 111e826 Compare December 24, 2024 08:10
@potiuk
Copy link
Member Author

potiuk commented Dec 24, 2024

I had to rebase it one-more time to make it fast-forward one.

@potiuk potiuk merged commit 111e826 into providers-fab/v1-5 Dec 24, 2024
20 checks passed
@potiuk
Copy link
Member Author

potiuk commented Dec 24, 2024

All right @eladkal -> the providers-fab/v1-5 branch tip now contains the back-ported changes and you should be able to chec out that branch and follow the regular process for 1.5.2 released of the fab provider (and only that provider) from that branch.

It's generally smooth and relatively simple - so far (even if I had to backport few changes).

We can indeed think of some improvements there. I will create an issue for it -> one idea I had is that we could have some code inbreeze that we could modify Provider's selective checks to only run tests for selected providers, not for all of them

@potiuk
Copy link
Member Author

potiuk commented Dec 24, 2024

I created an issue #45192 in our CI/DEV ENV project that describes how we can make future cases like that simpler to handle backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI area:providers area:UI Related to UI/UX. For Frontend Developers. provider:fab provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants