Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[providers-fab/v1-5] Invalidate user session on password reset (#45139) #45164

Closed

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 22, 2024

  • session expire on pass change

  • fix statis checks

  • add tests (cherry picked from commit cf401c4)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

Hmm. Still something wrong :(

@potiuk potiuk force-pushed the backport-fab-provider-commit branch 2 times, most recently from 82ba954 to c8a3de1 Compare December 22, 2024 21:28
@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

All right ! Now all workflows seems to be triggering !

@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

cc: @shubhamraj-git

Copy link
Member

@gopidesupavan gopidesupavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any change log update?

@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

Do we need any change log update?

It will be generated automatically - following the usual release provider process.

@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

Ah... I need to backport the click changes too :)

@potiuk potiuk force-pushed the backport-fab-provider-commit branch 2 times, most recently from 72b8e8b to d1d3440 Compare December 22, 2024 23:02
@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

And some more :)

shubhamraj-git and others added 5 commits December 23, 2024 14:23
…e#45139)

* session expire on pass change

* fix statis checks

* add tests
(cherry picked from commit cf401c4)

Co-authored-by: Shubham Raj <[email protected]>
* Fixing cli test failure in CI

* review comments

(cherry picked from commit 98e0977)
The 1.1.8 version of msgraph-core is buggy - importing some basic
classes causes import error "ABCMeta" is not subscriptable.

We are removing the version from azure provider dependencies hoping
that it will be fixed in the next version.

microsoftgraph/msgraph-sdk-python-core#781
(cherry picked from commit 3310b86)
This field (`dataplex_transfer_status`) got added in googleapis/google-cloud-python#13277 as part of `google-cloud-datacatalog==3.22.0`

(cherry picked from commit 060f75f)
* fix google datacatalog operator tests

* bump google-cloud-datacatalog

(cherry picked from commit f6bbc63)
@potiuk potiuk force-pushed the backport-fab-provider-commit branch from d1d3440 to 32e0e2b Compare December 23, 2024 13:35
@potiuk
Copy link
Member Author

potiuk commented Dec 23, 2024

I had to backport few fixes since that branch was relased - so it was a "bit" more involved - but all of them applied cleanly

The apache#45139 imported isabs from "airflow.www.app" - but isabs has
been added there fairly recently and it is anyhow stdlib's os.path
isabs - so it should be imported from there.

This breaks fab 1.5.2 backport compatibility tests, so we need to
cherry-pick it there alongside apache#45139

(cherry picked from commit 7002966)
@potiuk
Copy link
Member Author

potiuk commented Dec 23, 2024

Everything is green here, so cool. But I want to keep history of the commits, so I had to redo it from the "apache/airflow" repository and will merge it by pushing the providers-fab/v1-5 branch once approved there.

#45185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants