Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): upgrade webpack to 5.94.0 #28313

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

alan-agius4
Copy link
Collaborator

Addresses security vulnerability detailed in GHSA-4vvj-4cpr-p986.

Closes #28292

@alan-agius4 alan-agius4 added the target: lts This PR is targeting a version currently in long-term support label Aug 29, 2024
@alan-agius4 alan-agius4 force-pushed the bump-webpack-16 branch 5 times, most recently from 870e7cc to e3b3e07 Compare August 29, 2024 10:50
@alan-agius4 alan-agius4 requested a review from clydin August 29, 2024 11:05
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 29, 2024
@@ -34,7 +34,8 @@ describeBuilder(buildWebpackBrowser, BROWSER_BUILDER_INFO, (harness) => {
}
});

it('includes Webpack profiling information', async () => {
// TODO: Investigate why this profiling object is no longer present in Webpack 5.90.3+ and if this should even be tested
xit('includes Webpack profiling information', async () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already disabled in v17 branches.

@alan-agius4 alan-agius4 removed the request for review from clydin August 29, 2024 16:58
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 29, 2024
@alan-agius4 alan-agius4 merged commit 56fa051 into angular:16.2.x Aug 29, 2024
18 checks passed
@alan-agius4 alan-agius4 deleted the bump-webpack-16 branch August 29, 2024 16:58
@venkateshparihar
Copy link

@alan-agius4 Are you applying the same change for Angular 15 as well ?

@alan-agius4
Copy link
Collaborator Author

No, version 15 is no longer supported.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: lts This PR is targeting a version currently in long-term support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants