Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@angular-devkit/build-angular depends on vulnerable version of webpack - CVE-2024-43788 #28292

Closed
1 task
bgardner-noggin opened this issue Aug 28, 2024 · 9 comments

Comments

@bgardner-noggin
Copy link

bgardner-noggin commented Aug 28, 2024

Command

build

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

Running npm_audit on an Angular v18 project outputs the following

# npm audit report

webpack  <5.94.0
Severity: moderate
Webpack's AutoPublicPathRuntimeModule has a DOM Clobbering Gadget that leads to XSS - https://github.com/advisories/GHSA-4vvj-4cpr-p986
No fix available
node_modules/webpack
  @angular-devkit/build-angular  *
  Depends on vulnerable versions of webpack
  node_modules/@angular-devkit/build-angular

2 moderate severity vulnerabilities

Some issues need review, and may require choosing
a different dependency.

Minimal Reproduction

Create a new angular project using the latest v18 @angular-cli
Run npm audit in the project folder

Exception or Error

No response

Your Environment

_                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 18.2.1
Node: 20.16.0
Package Manager: npm 10.8.1
OS: linux x64

Angular: 
... 

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1802.1 (cli-only)
@angular-devkit/core         18.2.1 (cli-only)
@angular-devkit/schematics   18.2.1 (cli-only)
@schematics/angular          18.2.1 (cli-only)


### Anything else relevant?

_No response_
@angular angular deleted a comment Aug 28, 2024
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 28, 2024
@angular angular deleted a comment from ViniciusSCG Aug 28, 2024
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 28, 2024
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 28, 2024
@nicoobkio
Copy link

I see you are working on a fix; Can you give us an ETA for the release please ? :-)

alan-agius4 added a commit that referenced this issue Aug 28, 2024
@alan-agius4
Copy link
Collaborator

Closed via #28294

@alan-agius4
Copy link
Collaborator

A release should happen later today.

@SmartKent
Copy link

A release should happen later today.

Any patch for previous Angular version, like 17?

@poiuylkkk
Copy link

Any patch for previous Angular version, like 16?
@angular-devkit/[email protected] depends on [email protected], which also has the same vulnerability issue

alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 29, 2024
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 29, 2024
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 29, 2024
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 29, 2024
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 29, 2024
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 29, 2024
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 29, 2024
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 29, 2024
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 29, 2024
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 29, 2024
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 29, 2024
alan-agius4 added a commit that referenced this issue Aug 29, 2024
alan-agius4 added a commit that referenced this issue Aug 29, 2024
@Brice155
Copy link

Brice155 commented Sep 5, 2024

Any patch for previous Angular version, like 14 ?

"@angular-devkit/build-angular": { "version": "14.2.13", "requires": { [...] "webpack": "5.76.1", [...] },

@alan-agius4
Copy link
Collaborator

Versions prior to version 16 are no longer supported. See: https://angular.dev/reference/releases#actively-supported-versions

@programmingPug
Copy link

Will v17 be getting the patch?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants
@bgardner-noggin @alan-agius4 @Brice155 @programmingPug @poiuylkkk @nicoobkio @SmartKent and others