Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to pipeline #279

30 changes: 20 additions & 10 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,24 @@
version: 2.1

workflows:
version: 2
test:
jobs:
- unit-test
- integration-test

jobs:
build:
machine:
image: "ubuntu-2004:202104-01"
unit-test:
docker:
- image: python:3.7.9
steps:
- checkout
- run:
command: |
pip3 install -r requirements.txt
black --check .
set -e
python3 test_unit.py
make docker-test
- run: pip install -r requirements.txt
- run: black --check .
- run: python3 test_unit.py
integration-test:
machine:
image: "ubuntu-2004:202104-01"
steps:
- checkout
- run: make docker-test
6 changes: 6 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -113,3 +113,9 @@ venv.bak/
*.feature
test/features
test-harness

# Build files
py-algorand-sdk-*

# Pycharm
.idea
2 changes: 1 addition & 1 deletion algosdk/future/transaction.py
Original file line number Diff line number Diff line change
Expand Up @@ -2533,7 +2533,7 @@ def verify(self, public_key):
try:
verify_key.verify(to_sign, base64.b64decode(self.sig))
return True
except BadSignatureError:
except (BadSignatureError, ValueError):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: There was a change in pynacl that allows throwing a ValueError or TypeError in the verify function.

return False

return self.msig.verify(to_sign)
Expand Down
3 changes: 3 additions & 0 deletions test_unit.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import os
import random
import string
import sys
import unittest
import uuid
from unittest.mock import Mock
Expand Down Expand Up @@ -4317,3 +4318,5 @@ def test_contract(self):
suite = unittest.TestSuite(suites)
runner = unittest.TextTestRunner(verbosity=2)
results = runner.run(suite)
ret = not results.wasSuccessful()
sys.exit(ret)